Don't delete temp directory in fetch_via_vcs #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tushar Goel <[email protected]>
pombredanne
reviewed
Aug 24, 2022
| """ | ||
| if os.path.isdir(self.dest_dir): | ||
| shutil.rmtree(path=self.dest_dir) | ||
|
|
||
|
|
||
| def fetch_via_vcs(url): | ||
| """ | ||
| Take `url` as input and store the content of it at location specified at `location` string |
There was a problem hiding this comment.
There is no location arg here? Why create a temp directory and not accept instead a proper location?
JonoYang
pushed a commit
that referenced
this pull request
Jul 21, 2023
Bump github actions versions #75
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tushar Goel [email protected]