Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added config to run CI tests on travis #11

Merged
merged 1 commit into from
Mar 27, 2020
Merged

Added config to run CI tests on travis #11

merged 1 commit into from
Mar 27, 2020

Conversation

jimc404
Copy link
Contributor

@jimc404 jimc404 commented Mar 8, 2020

Fixes #7

What does this PR do?

I have added a .travis.yml config to run CI tests on travis.

Implementation

I added python 3.5 to 3.8 builds for linux, as they come pre-configured with travis the implementation is rather simple, installing the requirements and running pytest to run tests.

With MacOS, travis provides no out of the box way to run python builds. The installation begins with installing pyenv through homebrew and loading the python from the version supplied in the env. Test script is same as linux. After the script pyenv and homebrew folders are cached to cut the 5+ minute build time they take. Tests were configured for python 3.6 to 3.8.

Notes

  • This should be merged after merging Remove "pkg-resources==0.0.0" from requirements.txt #10 otherwise builds will fail due to the buggy entry in requirements.txt
  • MacOS builds for python 3.5 were not implemented as pyenv can't build python3.5 on MacOS with native configuration. This is due to the required openssl headers not being available and causing python ssl extension build to fail. Seeing that python 3.5 EOL is September this year I decided to not work on it.
  • Windows builds were not implemented as they again require implementing workarounds and writing windows scripts

Copy link
Contributor

@steven-esser steven-esser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested this at all? Just wondering before I merge.

@jimc404
Copy link
Contributor Author

jimc404 commented Mar 26, 2020 via email

@jimc404 jimc404 requested a review from steven-esser March 26, 2020 21:26
@jimc404
Copy link
Contributor Author

jimc404 commented Mar 26, 2020

@MaJuRG Here's the build log for this config

@steven-esser steven-esser merged commit 44fc169 into aboutcode-org:master Mar 27, 2020
JonoYang added a commit that referenced this pull request Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CI test suite
2 participants