Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package registry support for Homebrew packages #40

Open
TG1999 opened this issue Sep 25, 2020 · 17 comments
Open

Add package registry support for Homebrew packages #40

TG1999 opened this issue Sep 25, 2020 · 17 comments

Comments

@TG1999
Copy link
Collaborator

TG1999 commented Sep 25, 2020

Have a look at fetchcode/package.py , and try to implement the same for Homebrew packages.https://formulae.brew.sh/api/formula/a2ps.json, sample API URL.

@iamsairus10
Copy link

I looked into the issue #40 ....like package.py...we have to make a new file homebrew package with same code?or we have to do something else?

@TG1999
Copy link
Collaborator Author

TG1999 commented Oct 4, 2020

Hi @iamsairus10, You don't need to create a new file, check the structure of package.py, you have to create a route for homebrew packages like it is done for npm or PyPI packages.

@iamsairus10
Copy link

Screenshot 2020-10-04 at 10 34 15 PM

Like this???

@TG1999
Copy link
Collaborator Author

TG1999 commented Oct 4, 2020

Screenshot 2020-10-04 at 10 34 15 PM

Like this???

Yes!!

@iamsairus10
Copy link

what will be base path for this?
https://formulae.brew.sh/api/formula/a2ps.json
this one?

@iamsairus10
Copy link

Screenshot 2020-10-09 at 3 45 03 PM

Is it okay???
Or any changes req?

@TG1999
Copy link
Collaborator Author

TG1999 commented Oct 9, 2020

It will be difficult for us, to check code like this, would you like to write some tests for it ?

@iamsairus10
Copy link

yaa sure just guide me

@TG1999
Copy link
Collaborator Author

TG1999 commented Oct 9, 2020

Checkout tests/test_package.py file, and try to repeat same for npm or pypi

@iamsairus10
Copy link

There is no file as tests/data/homebrew_mock_data.json...
what should I do?

@iamsairus10
Copy link

Also no file as homebrew.json

@TG1999
Copy link
Collaborator Author

TG1999 commented Oct 9, 2020

Create one ;)

@iamsairus10
Copy link

How🥺??

@iamsairus10
Copy link

@TG1999 I am still unable to find how to approach to create those file?

@tushar912
Copy link

@TG1999 can I work on this

@TG1999
Copy link
Collaborator Author

TG1999 commented Feb 5, 2021

Sure go ahead

@tushar912
Copy link

@TG1999 I made a PR for this #47 .Can you review.

pombredanne pushed a commit that referenced this issue Feb 9, 2022
Add README.rst to etc/scripts/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants