Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate the Package notice_text from Scan "key files" #136 #137

Merged
merged 3 commits into from
Jun 26, 2024

Conversation

tdruez
Copy link
Contributor

@tdruez tdruez commented Jun 25, 2024

This implementation is similar to the way a copyright is "inferred" using the holder data from the Scan during the "update_from_scan" process when the Dataspace "Update packages automatically from scan" feature is enabled.

If a notice_text is not available directly on the "DETECTED PACKAGE" data returned in the Scan results, the key files content is used to generated content for the notice_text.
Only the key files with "notice" (case is ignored) in their filename are included.
In case of multiple "notice" key files, their content is combined before being assigned to the Package.notice_text

@DennisClark
Copy link
Member

@tdruez All my tests in staging were successful.

@tdruez tdruez merged commit 4651e25 into main Jun 26, 2024
5 checks passed
@tdruez tdruez deleted the 136-notice-text-from-key-files branch June 26, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants