Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement request: provide hint in package tree navigation #70

Closed
silverhook opened this issue Mar 28, 2024 · 3 comments
Closed

Enhancement request: provide hint in package tree navigation #70

silverhook opened this issue Mar 28, 2024 · 3 comments
Labels
design needed Design details needed to complete the issue enhancement New feature or request

Comments

@silverhook
Copy link

Is your enhancement request related to a problem? Please describe.

When navigating through the hierarchy, it is not apparent which package/dep has further deps.

For example in the following screenshot all the packages seem the same.

image

But if you click on Qt, it clearly has several dependencies.

image

What are the benefits of the requested enhancement?

It would make navigating the package hierarchy easier.

Describe the solution you would like

I think a visual indicator – e.g. a connector dot on the right-edge of the package bubble – would be enough.

@silverhook silverhook added design needed Design details needed to complete the issue enhancement New feature or request labels Mar 28, 2024
@pombredanne pombredanne changed the title Enhancement request: Enhancement request: provide hint in package tree navigation Apr 12, 2024
tdruez added a commit that referenced this issue May 29, 2024
tdruez added a commit that referenced this issue May 29, 2024
tdruez added a commit that referenced this issue May 29, 2024
tdruez added a commit that referenced this issue May 29, 2024
@tdruez
Copy link
Contributor

tdruez commented May 29, 2024

This PR #126 adds a link on the right side of a hierarchy item if it has any children.
It also displays a link on the left side when it has any parents.

Re-using the example from above:
Screenshot 2024-05-29 at 17 41 17
Screenshot 2024-05-29 at 17 41 38
Screenshot 2024-05-29 at 17 41 50

@DennisClark
Copy link
Member

@tdruez This enhancement looks really good in Staging Starship. I like the use of the dot to indicate that there is a link to more connections. (and I am reminded to take a closer look at somewhat related issue #87 )

@tdruez
Copy link
Contributor

tdruez commented May 30, 2024

PR merged and deployed.
@silverhook Thanks for suggesting this improvement 🚀

@tdruez tdruez closed this as completed May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design needed Design details needed to complete the issue enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants