-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve documentation for DejaCode integration with SCIO, VulnerableCode and PURLDB #31
Comments
@mjherzog There are sub-sections of the "Dataspace" section that should help: https://dejacode.readthedocs.io/en/latest/dataspace.html#enable-purldb-service https://dejacode.readthedocs.io/en/latest/dataspace.html#enable-vulnerablecodedb-service Apparently these might not be obvious since they are not in the "Installation" section, and we might want to refer to those links there as well. |
That is exactly my point - we need to explain the big picture upfront and not expect a new user to find it - TLDR principle I guess. |
@tdruez I have attached a modified copy of |
Signed-off-by: tdruez <[email protected]>
Signed-off-by: tdruez <[email protected]>
@tdruez Very impressive! All the improvements look good to me. |
@tomd - This looks very good to me! I have two comments:
|
Signed-off-by: tdruez <[email protected]>
Improve documentation for integrations setup #31
Documentation updates deployed at https://dejacode.readthedocs.io/ @mjherzog I've addressed your comments at: |
Looks good. I had forgotten also that API keys are not required for VulnerableCode and PurlDB. |
Our current instructions for installing DjC provides references to PURLDB and VulnerableCode in the Application Settings section, but there is no mention of the settings for SCIO integration.
The current documentation does not provide any information about which DejaCode features require integration with one or more of SCIO, VulnerableCode or PURLDB or the current options for installing these modules.
We need to document the functionality that depends on the installation and integration of other AboutCode projects and the current options for integration. We do not need to provide installation details that are better handled by the documentation for each project, but we need the big picture perspective from DejaCode.
The text was updated successfully, but these errors were encountered: