Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DJC: Ensure that we can run a scan from a PURL in DejaCode #131

Closed
pombredanne opened this issue Jun 10, 2024 · 7 comments
Closed

DJC: Ensure that we can run a scan from a PURL in DejaCode #131

pombredanne opened this issue Jun 10, 2024 · 7 comments

Comments

@pombredanne
Copy link
Member

When we get results from a front-end ScanCode.io, we may have only PURLs, with little to no extra data.
In particular we may miss the download URL in "skinny" scan results from the "inspect package" pipeline.

PurlDB knows how to collect metadata and run scans on the archives of a package using a PURL input. We need the same from DejaCode.

@DennisClark
Copy link
Member

This may require accessing data in private repos.

tdruez added a commit that referenced this issue Jun 11, 2024
tdruez added a commit that referenced this issue Jun 11, 2024
tdruez added a commit that referenced this issue Jun 11, 2024
tdruez added a commit that referenced this issue Jun 11, 2024
tdruez added a commit that referenced this issue Jun 11, 2024
tdruez added a commit that referenced this issue Jun 11, 2024
@tdruez
Copy link
Contributor

tdruez commented Jun 11, 2024

PR #133 introduces support for PURLs in the "Add Package" feature.

One or more PURL(s) can be submitted in place, or along download URL(s) in the "Add Package" modal.

If the PURL type is supported by the packageurl library purl2url, a download URL will be generated for creating the package and submitting a scan. If the download URL cannot be determined, the package is still created.

The second improvement is the addition of PurlDB lookup during the Add Package process.
Regardless if a Download URL or a PURL is provided, the PurlDB will be use to find the existing package there, and will use all the available data from the PurlDB to create the package.

tdruez added a commit that referenced this issue Jun 11, 2024
Signed-off-by: tdruez <[email protected]>
@DennisClark
Copy link
Member

@tdruez I tried a couple of PURLs from the PurlDB to add a new package but keep getting "Error: error" on the submission form. Please see attached screenshot.

Add package from a PURL 2024-06-11 at 08 00 19

@mjherzog mjherzog changed the title Ensure that we can run a scan from a PURL in DejaCode DJC: Ensure that we can run a scan from a PURL in DejaCode Jun 11, 2024
@tdruez
Copy link
Contributor

tdruez commented Jun 12, 2024

@DennisClark I cannot reproduce the error on my side, the Packages are successfully added.
Could you try to refresh your browser cache just in case?

@DennisClark
Copy link
Member

@tdruez Success! browser cache refreshed (which I thought I had done earlier, but never mind) and creating a new package from a PURL went quickly and smoothly. Looks good to me.

@DennisClark
Copy link
Member

@tdruez I also verified that the Add Package from a PURL will not create a duplicate Package if it already exists.

tdruez added a commit that referenced this issue Jun 13, 2024
tdruez added a commit that referenced this issue Jun 13, 2024
tdruez added a commit that referenced this issue Jun 13, 2024
tdruez added a commit that referenced this issue Jun 13, 2024
tdruez added a commit that referenced this issue Jun 13, 2024
tdruez added a commit that referenced this issue Jun 13, 2024
@tdruez
Copy link
Contributor

tdruez commented Jun 13, 2024

Feature merged and deployed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants