-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release candidate v0.3.7 alpha #57
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vent reentrancy attack (patch 01)
…ing stopped status
…atus' into rc-v0.3.7
…-hour' into rc-v0.3.7
…lows' into rc-v0.3.7
… and not terminal flow
…th-mints' into rc-v0.3.7
…-hour' into rc-v0.3.7
…s into one to save code size
Looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
code: V0.3.7 patch01 personal mint reentrancy #47
context:
personalMint()
reentrancy attack hats-finance/Circles-0x6ca9ca24d78af44582951825bef9eadcb210e5cf#8code: (hub): on update v1 status, never reduce lastMintTime to avoid resett… #48
context: User can reset the INDEFINITE_FUTURE mintTime hats-finance/Circles-0x6ca9ca24d78af44582951825bef9eadcb210e5cf#1
code: (Hub, InflatCRC, Circles): tidy up unused variable, docstring, comment #49
context: Issuance Calculation Incosinstency hats-finance/Circles-0x6ca9ca24d78af44582951825bef9eadcb210e5cf#3
code: V0.3.7 patch04 deploy erc20 only for humans and orgs #50
context: lack of check in
ensureERC20
compare towrap
Function hats-finance/Circles-0x6ca9ca24d78af44582951825bef9eadcb210e5cf#25code: V0.3.7 patch05 missing hour when minting exactly on the hour #51
context: Incorrect Calculation of Remaining Hours in Day B in
_calculateIssuance
Function hats-finance/Circles-0x6ca9ca24d78af44582951825bef9eadcb210e5cf#39code: (hub): correct trivial error in error in _matchNettedFlows #52
context: Incorrect
error
revert in_matchNettedFlows()
function hats-finance/Circles-0x6ca9ca24d78af44582951825bef9eadcb210e5cf#41code: (hub, circles): suppress group mint's acceptance call if along a path… #53
context: Inefficient Token Transfer Handling for Middle Vertices Groups in
_effectPathTransfers
Function hats-finance/Circles-0x6ca9ca24d78af44582951825bef9eadcb210e5cf#46code: (demurrage): small possible gas optimisation #54
context:
else-block
is not needed hats-finance/Circles-0x6ca9ca24d78af44582951825bef9eadcb210e5cf#44code: (migration): require migration amount to be greater than zero #55
context: Zero-Amount Vulnerability in
migrate
Function Allows Unauthorized Migration hats-finance/Circles-0x6ca9ca24d78af44582951825bef9eadcb210e5cf#50code: (InflationaryOperator): initialise inflationDayZero from Hub #56
context: in InflationaryOperator this should also have been initialised
code: V0.3.7 patch11 improve events in standard treasury #58
context: wrong mint emission in treasury contract hats-finance/Circles-0x6ca9ca24d78af44582951825bef9eadcb210e5cf#85
code: (errors): rename variable in error for correctness #59
context: Incorrect error revert in
operateFlowMatrix()
function hats-finance/Circles-0x6ca9ca24d78af44582951825bef9eadcb210e5cf#106code: (nameRegistry): check short name is not zero #60
context: It is possible for
shortName
to be calculated as the 0 bytes, breaking certain invariants hats-finance/Circles-0x6ca9ca24d78af44582951825bef9eadcb210e5cf#113code: (nameRegistry): remove restriction only registered address can regist… #61
context: request from internal for v2 invitation flow to store metadata, v1 (and v3+) compatibility, and error on blocking view functions
code: V0.3.7 patch15 improve hourly check #64
context: Unnecessary Hourly Check in
_calculateIssuance
Function Prevents Users from Receiving Rewards hats-finance/Circles-0x6ca9ca24d78af44582951825bef9eadcb210e5cf#114code: (StandardTreasury): correct data passed to be user data to policy for… #62
context: for group redeem the data passed should also have been
UserData
; our base policy would not have worked with thiscode: V0.3.7 patch17 reduce compile size by compressing errors #65
context: reducing code compile size with compressing errors and collapsing requirements together mostly
code: V0.3.7 patch18 reintroduce events #66
context: with spare room, re-introduce some valuable events
code: (nameRegistry): register hub as Circles (CRC) in name registry #67
context: register
hub
address as name "Circles", symbol "CRC" inNameRegistry
in constructor