Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly require hydra package #39

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

leotaku
Copy link

@leotaku leotaku commented Sep 4, 2021

I have noticed that, on some versions of Emacs, requiring worf fails with a void-variable error on hydra-worf-change.
This user here abo-abo/pamparam#34 also seems to be getting the same error.

I do not fully understand why, but adding (require 'hydra) to the worf.el file has completely fixed this issue for me.
Please feel free to just close this PR if you want, as I'm not able to give a good justification of why this works.

I have noticed that, on some versions of Emacs, requiring `worf` fails with a void-variable error on `hydra-worf-change`. 
This user here abo-abo/pamparam#34 also seems to be getting the same error.

I do not fully understand why, but adding `(require 'hydra)` to the `worf.el` file has completely fixed this issue for me.
Please feel free to just close this PR if you want, as I'm not able to give a good justification of why this works.
@DeLevely DeLevely mentioned this pull request Oct 9, 2022
@LemonBreezes
Copy link

LemonBreezes commented Apr 6, 2023

I have noticed that, on some versions of Emacs, requiring worf fails with a void-variable error on hydra-worf-change. This user here abo-abo/pamparam#34 also seems to be getting the same error.

I do not fully understand why, but adding (require 'hydra) to the worf.el file has completely fixed this issue for me. Please feel free to just close this PR if you want, as I'm not able to give a good justification of why this works.

The issue is that Hydra is not being loaded during byte compilation so it's not handling defhydra correctly. Another fix is to add (eval-when-compile (require 'hydra)). However, since the defhydra blocks are not autoloaded in a separate file, hydra will get pulled in anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants