counsel-git-grep doesn't wait for three chars on Windows

[parbo]

Because counsel--git-grep-count is set to 0 when system-type is windows-nt, counsel-git-grep doesn't wait for three chars on big repos on windows. It takes 20s or so to open counsel-git-grep on my +1M line project, and quite a lot of time for each char until the number of matches are reduced.

Maybe it should rather be set to a number > 20000? Or it could be possible to customize the behavior?

[abo-abo]

It used to wait on Windows, but it wasn't working very well, so I disabled it. If you can make it work well, a PR is welcome.

[parbo]

I could try. My point is that the current behavior defeats the purpose of not counting the lines, since it will now do a grep of the empty string. Which has the same effect. I think it would be better to assume the repo is large than to assume it's small.

[abo-abo]

since it will now do a grep of the empty string

That's what I wanted it to do. The standard method of calling a new grep process after each keystroke does not work well on Windows.

[parbo]

So the grep process is re-used? Can't you spawn that process at three chars instead, so that the initial grep isn't horribly slow?

[abo-abo]

So the grep process is re-used? Can't you spawn that process at three chars instead, so that the initial grep isn't horribly slow?

It's not reused, it's spawned again. Which is fine on Linux but bad on Windows with its horrible process management. I could spawn the process at 3 chars, but then you can't edit the input out of these 3 chars: they will always be matched.

[fpopineau]

@abo-abo Why do you say it wasn't working well on Windows? I disabled the 0 count for windows-nt and tried a couple of counsel-git-grep in the emacs git repository. It seems to work fine, even with 20000 results.

[abo-abo]

@fpopineau Maybe I got a glitch. Might need further testing. What Git and Emacs versions you use?

[fpopineau]

Git version is:

$ git --version
git version 2.10.2

and emacs is 25.1 from git repo emacs-25 branch, compiled under msys2/mingw64.