Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make org-download-edit also work for attachment links. #182

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make org-download-edit also work for attachment links. #182

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions org-download.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -636,12 +636,19 @@ It's inserted before the image link and is used to annotate it.")
(let ((context (org-element-context)))
(if (not (eq (car-safe context) 'link))
(user-error "Not on a link")
(start-process-shell-command
"org-download-edit"
"org-download-edit"
(format org-download-edit-cmd
(shell-quote-wildcard-pattern
(url-unhex-string (plist-get (cadr context) :path))))))))
(let* ((filename (url-unhex-string (plist-get (cadr context) :path)))
(type (plist-get (car (cdr context)) :type))
Copy link
Author

@floli floli Oct 26, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe someone knows a nicer formulation of that line? The (car (cdr context)) part.

(filepath (if (string= type "attachment")
(org-attach-expand filename)
filename
))
)
(start-process-shell-command
"org-download-edit"
"*org-download-edit*"
(format org-download-edit-cmd
(shell-quote-wildcard-pattern filepath)))))))


(defun org-download--delete (beg end &optional times)
"Delete inline image links and the files they point to between BEG and END.
Expand Down