Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qutils reformatting and optimization #187

Open
wants to merge 3 commits into
base: new-master
Choose a base branch
from

Conversation

UshakovMikhail
Copy link

Changed our median and percentile functions with numpy ones. Changed check_dirpath function and added unittests for it

…check_dirpath function and added unittests for it
@alexeigurevich
Copy link
Contributor

Seems OK to me!
But I think we should not merge it into master right now since we yet want to release master as Quast v.5.1.0 with Python2 compatibility.
What about fork quast-ng or quast-6 branch from master and merging Misha's step-by-step changes there? @almiheenko what do you think?

Copy link
Contributor

@alexeigurevich alexeigurevich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK!

@UshakovMikhail UshakovMikhail changed the base branch from master to new-master November 9, 2021 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants