Skip to content

Commit

Permalink
Remove banking stage forwarder counters (anza-xyz#2788)
Browse files Browse the repository at this point in the history
The counters are either unused or have the data covered by a different
datapoint
  • Loading branch information
steviez authored and ray-kast committed Nov 27, 2024
1 parent 8ffd6de commit 7f3a43a
Showing 1 changed file with 4 additions and 8 deletions.
12 changes: 4 additions & 8 deletions core/src/banking_stage/forwarder.rs
Original file line number Diff line number Diff line change
Expand Up @@ -228,11 +228,13 @@ impl Forwarder {
usize,
Option<Pubkey>,
) {
let (res, num_packets, forward_us, leader_pubkey) =
let (res, num_packets, _forward_us, leader_pubkey) =
self.forward_packets(forward_option, forwardable_packets);
if let Err(ref err) = res {
warn!("failed to forward packets: {err}");
}

if num_packets > 0 {
inc_new_counter_info!("banking_stage-forwarded_packets", num_packets);
if let ForwardOption::ForwardTpuVote = forward_option {
banking_stage_stats
.forwarded_vote_count
Expand All @@ -242,12 +244,6 @@ impl Forwarder {
.forwarded_transaction_count
.fetch_add(num_packets, Ordering::Relaxed);
}

inc_new_counter_info!("banking_stage-forward-us", forward_us as usize, 1000, 1000);

if res.is_err() {
inc_new_counter_info!("banking_stage-forward_packets-failed-batches", 1);
}
}

(res, num_packets, leader_pubkey)
Expand Down

0 comments on commit 7f3a43a

Please sign in to comment.