switches to specify vertical and horizontal char densities #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge stable with changes from master
Version bump!
Update version!
Thanks @abishekvashok, conflicts to master resolved. |
abishekvashok
requested changes
Sep 8, 2021
| @@ -606,6 +639,16 @@ if (console) { | |||
| case '9': | |||
| update = keypress - 48; | |||
| break; | |||
| case 'm': | |||
| space += 10; | |||
There was a problem hiding this comment.
The indentation seems off in some places like this line for example. Can you please fix this
| @@ -629,7 +672,7 @@ if (console) { | |||
| case 'r': | |||
| rainbow = 1; | |||
| break; | |||
| case 'm': | |||
| case 'M': | |||
There was a problem hiding this comment.
Instead of modifying an existing option, can we switch the new option to use another letter or capital M if no other letters seem fit for the cause?
| @@ -81,6 +81,8 @@ int xwindow = 0; | |||
| int lock = 0; | |||
| cmatrix **matrix = (cmatrix **) NULL; | |||
| int *length = NULL; /* Length of cols in each line */ | |||
| int space = 50; /* vertical density parameter */ | |||
There was a problem hiding this comment.
Can we make them constants? (I am not sure if we modify them later, can you check?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (originally based on v1.2a) offers switches to specify vertical and horizontal character densities and the options to change these during run-time.