forked from ansible-collections/community.aws
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add argspec validation for targets (ansible-collections#1355)
cloudwatchevent_rule - Add argspec validation for targets SUMMARY fixes: ansible-collections#201 Targets currently has minimal validation applied. Because of the way Ansible converts JSON strings to dicts/lists, then back to the Python format string representing the dicts/lists, unless we explicitly define a parameter is a JSON string they get corrupted. This also moves the new input_paths_map/input_template parameters under input_transformer. Because we've not released 4.1.0 yet this doesn't cause any breakage. This will make adding other target parameters simpler further down the road. (There's a lot that we don't support today) ISSUE TYPE Bugfix Pull Request COMPONENT NAME cloudwatchevent_rule ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@5f0e10e
- Loading branch information
Showing
3 changed files
with
112 additions
and
62 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 5 additions & 5 deletions
10
tests/integration/targets/cloudwatchevent_rule/defaults/main.yml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,9 @@ | ||
--- | ||
name_pattern: "cloudwatch_event_rule" | ||
unique_id: "{{ tiny_prefix }}" | ||
name_pattern: "cloudwatch_event_rule-{{ tiny_prefix }}" | ||
|
||
test_event_names: | ||
- "{{ name_pattern }}-{{ unique_id }}-1" | ||
- "{{ name_pattern }}-{{ unique_id }}-2" | ||
- "{{ name_pattern }}-1" | ||
- "{{ name_pattern }}-2" | ||
|
||
input_transformer_event_name: "{{ name_pattern }}-{{ unique_id }}-3" | ||
input_transformer_event_name: "{{ name_pattern }}-3" | ||
input_event_name: "{{ name_pattern }}-4" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters