Skip to content

Commit

Permalink
Bump 2024 deprecations from dates to release versions (ansible-collec…
Browse files Browse the repository at this point in the history
…tions#2082)

Bump 2024 deprecations from dates to release versions

SUMMARY
Bump 2024 deprecations from dates to release versions
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
plugins/modules/ecs_cluster.py
plugins/modules/ecs_service.py
plugins/modules/glue_connection.py
ADDITIONAL INFORMATION
See also:
ansible-collections#518
ansible-collections#1640
ansible-collections#1716

Reviewed-by: Alina Buzachis
  • Loading branch information
tremble authored May 6, 2024
1 parent 2e8289f commit c065fd3
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 7 deletions.
9 changes: 9 additions & 0 deletions changelogs/fragments/9-date-deprecations.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
deprecated_features:
- aws_glue_connection - updated the deprecation for removal of the ``connection_parameters`` return key from ``after 2024-06-01`` to release version ``9.0.0``,
it is being replaced by the ``raw_connection_parameters`` key (https://github.com/ansible-collections/community.aws/pull/518).
- ecs_cluster - updated the deprecation for updated default of ``purge_capacity_providers``, the current default of ``False`` will be changed to ``True``
in release ``9.0.0``. To maintain the current behaviour explicitly set ``purge_capacity_providers=False`` (https://github.com/ansible-collections/community.aws/pull/1640).
- ecs_service - updated the deprecation for updated default of ``purge_placement_constraints``, the current default of ``False`` will be changed to ``True``
in release ``9.0.0``. To maintain the current behaviour explicitly set ``purge_placement_constraints=False`` (https://github.com/ansible-collections/community.aws/pull/1716).
- ecs_service - updated the deprecation for updated default of ``purge_placement_strategy``, the current default of ``False`` will be changed to ``True``
in release ``9.0.0``. To maintain the current behaviour explicitly set ``purge_placement_strategy=False`` (https://github.com/ansible-collections/community.aws/pull/1716).
6 changes: 3 additions & 3 deletions plugins/modules/ecs_cluster.py
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
version_added: 5.2.0
description:
- Toggle overwriting of existing capacity providers or strategy. This is needed for backwards compatibility.
- By default I(purge_capacity_providers=false). In a release after 2024-06-01 this will be changed to I(purge_capacity_providers=true).
- By default I(purge_capacity_providers=false). In release 9.0.0 this default will be changed to I(purge_capacity_providers=true).
required: false
type: bool
default: false
Expand Down Expand Up @@ -292,9 +292,9 @@ def main():
# Unless purge_capacity_providers is true, we will not be updating the providers or strategy.
if not purge_capacity_providers:
module.deprecate(
"After 2024-06-01 the default value of purge_capacity_providers will change from false to true."
"In release 9.0.0 the default value of purge_capacity_providers will change from false to true."
" To maintain the existing behaviour explicitly set purge_capacity_providers=true",
date="2024-06-01",
version="9.0.0",
collection_name="community.aws",
)
cps_update_needed = False
Expand Down
4 changes: 2 additions & 2 deletions plugins/modules/ecs_service.py
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@
version_added: 5.3.0
description:
- Toggle overwriting of existing placement constraints. This is needed for backwards compatibility.
- By default I(purge_placement_constraints=false). In a release after 2024-06-01 this will be changed to I(purge_placement_constraints=true).
- By default I(purge_placement_constraints=false). In release 9.0.0 this will be changed to I(purge_placement_constraints=true).
required: false
type: bool
default: false
Expand All @@ -180,7 +180,7 @@
version_added: 5.3.0
description:
- Toggle overwriting of existing placement strategy. This is needed for backwards compatibility.
- By default I(purge_placement_strategy=false). In a release after 2024-06-01 this will be changed to I(purge_placement_strategy=true).
- By default I(purge_placement_strategy=false). In release 9.0.0 this will be changed to I(purge_placement_strategy=true).
required: false
type: bool
default: false
Expand Down
4 changes: 2 additions & 2 deletions plugins/modules/glue_connection.py
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@
connection_properties:
description:
- (deprecated) A dict of key-value pairs (converted to lowercase) used as parameters for this connection.
- This return key has been deprecated, and will be removed in a release after 2024-06-01.
- This return key has been deprecated, and will be removed in release 9.0.0.
returned: when state is present
type: dict
sample: {'jdbc_connection_url':'jdbc:mysql://mydb:3306/databasename','username':'x','password':'y'}
Expand Down Expand Up @@ -337,7 +337,7 @@ def create_or_update_glue_connection(connection, connection_ec2, module, glue_co
"The 'connection_properties' return key is deprecated and will be replaced"
" by 'raw_connection_properties'. Both values are returned for now."
),
date="2024-06-01",
version="9.0.0",
collection_name="community.aws",
)
glue_connection["RawConnectionProperties"] = glue_connection["ConnectionProperties"]
Expand Down

0 comments on commit c065fd3

Please sign in to comment.