Skip to content

Commit

Permalink
Integration test dependency cleanup (ansible-collections#1086)
Browse files Browse the repository at this point in the history
Integration test dependency cleanup

SUMMARY

remove dependencies on setup_remote_tmp_dir where it's not used (often just copy & paste from another test)
remove setup_ec2 (no main.yml means it's not doing anything)
remove prepare_tests (empty main.yml means it's not doing anything)

ISSUE TYPE

Feature Pull Request

COMPONENT NAME
tests/integration/targets
ADDITIONAL INFORMATION
By cleaning up what we have we reduce the chance of people copying things about "because that's what test XYZ did".

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Mark Woolley <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@dd12046
  • Loading branch information
tremble authored and goneri committed Sep 23, 2022
1 parent 8b97034 commit dd06801
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 4 deletions.
4 changes: 1 addition & 3 deletions tests/integration/targets/rds_param_group/meta/main.yml
Original file line number Diff line number Diff line change
@@ -1,3 +1 @@
dependencies:
- prepare_tests
- setup_ec2
dependencies: []
1 change: 0 additions & 1 deletion tests/integration/targets/rds_param_group/tasks/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
# TODO - name: test 'validate_certs' parameter

# ============================================================
# - include: ../../setup_ec2/tasks/common.yml module_name=rds_param_group

- name: rds_option_group tests
collections:
Expand Down

0 comments on commit dd06801

Please sign in to comment.