Skip to content

Commit

Permalink
elb_instance - remove ec2_elbs fact (ansible-collections#1173)
Browse files Browse the repository at this point in the history
elb_instance - remove ec2_elbs fact

SUMMARY
The ec2_elbs fact was deprecated when we migrated to boto3, remove it.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
elb_instance
ADDITIONAL INFORMATION
See also: ansible-collections#773

Reviewed-by: Alina Buzachis <None>
  • Loading branch information
tremble authored and abikouo committed Sep 18, 2023
1 parent 69fd701 commit ce17c05
Showing 1 changed file with 2 additions and 7 deletions.
9 changes: 2 additions & 7 deletions elb_instance.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,8 @@
default: 0
type: int
notes:
- The ec2_elb fact currently set by this module has been deprecated and will no
longer be set after release 4.0.0 of the collection.
- The ec2_elbs fact previously set by this module was deprecated in release 2.1.0 and since release
4.0.0 is no longer set.
extends_documentation_fragment:
- amazon.aws.aws
- amazon.aws.ec2
Expand Down Expand Up @@ -388,13 +388,8 @@ def main():
elif module.params['state'] == 'absent':
elb_man.deregister(wait, timeout)

# XXX We're not an _fact module we shouldn't be returning a fact and poluting
# the namespace
ansible_facts = {'ec2_elbs': [lb['LoadBalancerName'] for lb in elb_man.lbs]}

module.exit_json(
changed=elb_man.changed,
ansible_facts=ansible_facts,
updated_elbs=list(elb_man.updated_elbs),
)

Expand Down

0 comments on commit ce17c05

Please sign in to comment.