Skip to content

Commit

Permalink
Integration test dependency cleanup (ansible-collections#1086)
Browse files Browse the repository at this point in the history
Integration test dependency cleanup

SUMMARY

remove dependencies on setup_remote_tmp_dir where it's not used (often just copy & paste from another test)
remove setup_ec2 (no main.yml means it's not doing anything)
remove prepare_tests (empty main.yml means it's not doing anything)

ISSUE TYPE

Feature Pull Request

COMPONENT NAME
tests/integration/targets
ADDITIONAL INFORMATION
By cleaning up what we have we reduce the chance of people copying things about "because that's what test XYZ did".

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Mark Woolley <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@dd12046
  • Loading branch information
tremble authored and abikouo committed Oct 18, 2024
1 parent 8c803cd commit 390e036
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions tests/integration/targets/ec2_launch_template/meta/main.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
dependencies:
- prepare_tests
- setup_ec2
- setup_ec2_facts
- setup_remote_tmp_dir
- role: setup_botocore_pip
vars:
boto3_version: "1.20.30"

0 comments on commit 390e036

Please sign in to comment.