Skip to content

Commit

Permalink
Add ec2_lc* integration tests (ansible-collections#824)
Browse files Browse the repository at this point in the history
Add ec2_lc* integration tests

SUMMARY

Added integration tests which exercise ec2_lc, ec2_lc_find, and ec2_lc_info.

ISSUE TYPE


Feature Pull Request

ADDITIONAL INFORMATION


ec2_lc (launch configurations) work with ASGs (auto-scaling groups) to define launch config for instances in the ASG.
We have tests for ec2_asg that make use of ec2_lc but as it is slow already, it makes sense to have a dedicated test suite for ec2_lc.

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Mandar Kulkarni <[email protected]>
Reviewed-by: Jill R <None>
Reviewed-by: Markus Bergholz <[email protected]>
  • Loading branch information
mandar242 authored and abikouo committed Sep 18, 2023
1 parent f61b4e0 commit 21e4dfe
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion ec2_lc.py
Original file line number Diff line number Diff line change
Expand Up @@ -478,7 +478,7 @@ def create_block_device_meta(module, volume):
if 'no_device' in volume:
return_object['NoDevice'] = volume.get('no_device')

if any(key in volume for key in ['snapshot', 'volume_size', 'volume_type', 'delete_on_termination', 'ips', 'encrypted']):
if any(key in volume for key in ['snapshot', 'volume_size', 'volume_type', 'delete_on_termination', 'iops', 'encrypted']):
return_object['Ebs'] = {}

if 'snapshot' in volume:
Expand Down

0 comments on commit 21e4dfe

Please sign in to comment.