-
-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AZURE support #186
base: main
Are you sure you want to change the base?
Add AZURE support #186
Conversation
Apply Sweep Rules to your PR?
|
|
||
pprint_prompt(prompt_messages) | ||
|
||
async def process_chunk(content: str): | ||
pass | ||
|
||
if not openai_api_key and not azure_openai_api_key: | ||
raise Exception("OpenAI API or Azure key not found") | ||
|
||
if not openai_api_key: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't you swap the condition with azure here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i will check if there is one of two, is missing all raise exception (but maybe is better have 2 separate checks)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to rework this a bit today before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR! Excited to get it in.
I just need it, thanks for the contribution |
which works better, Azure or OpenAI? |
They are the same model. Should work the same. |
you can upload customized data and set api rate limit in Azure. |
Great! I just want to know when will this PR be merged... |
Sorry for the slowness (catching up after the holidays). Should be merged some time next week. |
@abi Will this be merged in this week? Waiting for using it... |
@thuzhf Azure GPT 4 Vision has low token limits per minute so this hasn't been a priority for me. Have you tried cloning cristianorevil:azure-support and using it directly? You don't need to wait for this to be merged in to use it. |
Since stream requests are already supported and the issue with token limitations has been somewhat improved, can we support Azure now? |
This PR add the support for Azure OpenAI Services (Vision & DALLE-3)
Some considerations:
My tests with AZURE are ok, please test also OPENAI