Skip to content

Commit

Permalink
deps: float ea7abee from openssl / CVE-2018-0732
Browse files Browse the repository at this point in the history
Pending OpenSSL 1.1.0i release.

PR-URL: nodejs/node#21282
Reviewed-By: Shigeki Ohtsu <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Upstream: openssl/openssl@ea7abee

Original commit message:

    Reject excessively large primes in DH key generation.

    CVE-2018-0732

    Signed-off-by: Guido Vranken <[email protected]>

    (cherry picked from commit 91f7361f47b082ae61ffe1a7b17bb2adf213c7fe)

    Reviewed-by: Tim Hudson <[email protected]>
    Reviewed-by: Matt Caswell <[email protected]>
    (Merged from openssl/openssl#6457)
  • Loading branch information
rvagg committed Jun 15, 2018
1 parent 2749460 commit 772d390
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion deps/openssl/openssl/crypto/dh/dh_key.c
Original file line number Diff line number Diff line change
Expand Up @@ -78,10 +78,15 @@ static int generate_key(DH *dh)
int ok = 0;
int generate_new_key = 0;
unsigned l;
BN_CTX *ctx;
BN_CTX *ctx = NULL;
BN_MONT_CTX *mont = NULL;
BIGNUM *pub_key = NULL, *priv_key = NULL;

if (BN_num_bits(dh->p) > OPENSSL_DH_MAX_MODULUS_BITS) {
DHerr(DH_F_GENERATE_KEY, DH_R_MODULUS_TOO_LARGE);
return 0;
}

ctx = BN_CTX_new();
if (ctx == NULL)
goto err;
Expand Down

0 comments on commit 772d390

Please sign in to comment.