Fix bug with error handling and await for context.sync()

abhinavrau · Aug 22, 2024 · d3ac557 · d3ac557
1 parent 71720ff
commit d3ac557
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/src/search_runner.js b/src/search_runner.js
@@ -285,7 +285,7 @@ function checkDocumentLinks(rowNum, result, link_1_Column, link_2_Column, link_3
     const cell = actualSummaryColumn.getRange().getCell(rowNum, 0);
     cell.clear(Excel.ClearApplyTo.formats);
     cell.values = [[result.summary.summaryText]];
-    context.sync();
+    await context.sync();
     // match summaries only if they are not null or empty
     if (expectedSummary[rowNum][0] !== null && expectedSummary[rowNum][0] !== "") {
         const score_cell = summaryScoreColumn.getRange().getCell(rowNum, 0);
@@ -317,7 +317,7 @@ function checkDocumentLinks(rowNum, result, link_1_Column, link_2_Column, link_3
 
         }
         finally {
-            context.sync();
+            await context.sync();
         }
 
     }

diff --git a/src/summarization_runner.js b/src/summarization_runner.js
@@ -26,7 +26,7 @@ export async function getSummarizationConfig() {
             const worksheetName = currentWorksheet.name;
             const configTable = currentWorksheet.tables.getItem(`${worksheetName}.ConfigTable`);
             const valueColumn = getColumn(configTable, "Value");
-            await context.sync();
+
 
             config = {
                 vertexAIProjectID: valueColumn.values[1][0],
@@ -227,7 +227,7 @@ async function processResponse(rowNum,
     const cell_summary = summaryColumn.getRange().getCell(rowNum, 0);
     cell_summary.clear(Excel.ClearApplyTo.formats);
     cell_summary.values = [[output]];
-    context.sync();
+    await context.sync();
 
 
     try {
@@ -262,7 +262,7 @@ async function processResponse(rowNum,
         cell_status.format.fill.color = '#FFCCCB';
         cell_status.values = [["Failed. Error: " + err.message]];
     } finally {
-        context.sync();
+        await context.sync();
     }
 
 

diff --git a/src/ui.js b/src/ui.js
@@ -25,13 +25,13 @@ export function appendError(message, error) {
     const newLogEntry = {
         time: new Date().toLocaleTimeString(), // Get only time
         level: error !== null ? "ERROR" : "INFO",
-        message: error !== null ? message + '\n' + error.message : message
+        message: error !== null ? "message:" + message + "ErrMesg:" + error.message : message
     };
 
     $("#log-pane").tabulator("addRow", newLogEntry, "top"); // Add the new log entry to the top of the table
 
     if (error !== null) {
-        console.error(message + '\n' + error.message);
+        console.error("message:" + message + "ErrMesg:" + error.message);
     } else {
         console.log(message);
     }