-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'lineshuffle' command #715
Conversation
This use of |
docs/conf.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was changed by 'ruff check --fix', not something I did manually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, whatever :)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #715 +/- ##
=======================================
Coverage 94.68% 94.69%
=======================================
Files 62 62
Lines 5777 5783 +6
Branches 1275 1278 +3
=======================================
+ Hits 5470 5476 +6
Misses 189 189
Partials 118 118 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice addition! I've actually been wanting it multiple times before. Everything looks good, except for that symlink situation that needs to be reverted, and that extra test that can probably go.
docs/conf.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, whatever :)
Quality Gate passedIssues Measures |
I simplified a bit the doc string, and realised that I could also significantly simplify the code :) |
Description
Adds a 'lineshuffle' layer processor to randomize the plotting order of lines in the current geometry. Useful in some niche cases where a plotting-time optimized file is not ideal.
Checklist
black
andruff check .
)mypy
returns no errorpytest
succeedshelp
reference.rst
make clean && make html
indocs/
)