Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where the ImageRenderer's GL context wasn't released #616

Merged
merged 4 commits into from
Mar 21, 2023

Conversation

abey79
Copy link
Owner

@abey79 abey79 commented Mar 19, 2023

Description

This caused an issue when running the test suite, which could involve creating multiple hundreds of context, ultimately leading to a crash.

More info: moderngl/moderngl#575

Excluded poetry version 1.4.1 due to validation issue with some packages, see python-poetry/poetry#7686 and pradyunsg/furo#639

Checklist

  • feature/fix implemented
  • code formatting ok (black and isort)
  • mypy returns no error
  • tests added/updated and pytest succeeds
  • documentation added/updated
    • command docstring and option/argument help
    • README.md updated (Feature Overview)
    • CHANGELOG.md updated
    • added new command to reference.rst
    • RTD doc updated and building with no error (make clean && make html in docs/)

abey79 added 2 commits March 19, 2023 21:26
This caused an issue when running the test suite, which could involve creating multiple hundreds of context, ultimately leading to a crash.
@codecov
Copy link

codecov bot commented Mar 19, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (7106a71) 94.77% compared to head (0921636) 94.77%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #616   +/-   ##
=======================================
  Coverage   94.77%   94.77%           
=======================================
  Files          62       62           
  Lines        5719     5721    +2     
  Branches     1304     1304           
=======================================
+ Hits         5420     5422    +2     
  Misses        182      182           
  Partials      117      117           
Impacted Files Coverage Δ
vpype_viewer/image/__init__.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@abey79 abey79 merged commit dcd52bd into master Mar 21, 2023
@abey79 abey79 deleted the fix-context-release branch March 21, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant