Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin the version of some dependencies for readthedoc #469

Merged
merged 3 commits into from
Jan 9, 2023

Conversation

oooo26
Copy link
Collaborator

@oooo26 oooo26 commented Jan 9, 2023

From the building log, I find readthedoc use different version on some packages, e.g. Sphinx, compared to before.
It may cause the wrong format.

Now I pin some packages Sphinx==4.5.0, docutils==0.17.1 and sphinx-rtd-theme===1.1.1, which were worked before. This also fix #468, so I unpinned Jinja2.

@oooo26 oooo26 changed the title Fix readthedoc format Pin the version of some dependencies for readthedoc Jan 9, 2023
@oooo26
Copy link
Collaborator Author

oooo26 commented Jan 9, 2023

There seems still a problem in rendering the list and I found readthedocs/sphinx_rtd_theme#1115 .

Will update soon.

@codecov
Copy link

codecov bot commented Jan 9, 2023

Codecov Report

Base: 96.22% // Head: 96.19% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (a134343) compared to base (d754e55).
Patch coverage: 90.90% of modified lines in pull request are covered.

❗ Current head a134343 differs from pull request most recent head 928364f. Consider uploading reports for the commit 928364f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #469      +/-   ##
==========================================
- Coverage   96.22%   96.19%   -0.03%     
==========================================
  Files          28       28              
  Lines        3043     3051       +8     
==========================================
+ Hits         2928     2935       +7     
- Misses        115      116       +1     
Flag Coverage Δ
Python 97.26% <90.90%> (-0.08%) ⬇️
rpackage 95.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/abess/linear.py 98.75% <90.90%> (-0.39%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@oooo26
Copy link
Collaborator Author

oooo26 commented Jan 9, 2023

Sphinx==4.5.0, docutils<0.17 solved the problem.

@oooo26 oooo26 merged commit db62b47 into abess-team:master Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant