Unmutes a few seconds too early, playing endings of ads.

[roadie]

Using Essential phone PH-1, using latest version of Spotify and Ad-Free. Most of the time, the phone would unmute before the ad finishes so a few seconds of ads would be played. Is there any way to unmute at the right time? Even just extend a few more seconds to mute the music would be less distracting.

[abertschi]

I don't observe your described behavior on my devices. Does it happen with all ads? What ad-blocking plugin did you select in ad-free settings? Can you create a video of your phone showing the notification drawer and the spotify and ad-free notifications when ads play? If you do so I will consider implementing such adjustment parameters but I first want to see the issue myself.

[roadie]

It doesn't happen to all the ads. And the behaviour is not the same all the time either. Sometimes it blocks the ads perfectly, sometimes it ends one second before the ad finishes, sometimes a free seconds, and occasionally half the ad is played.

I chose mute audio.

I don't have time to create a video to show this yet. I have to find another phone to record it so it'll take some effort. But basically the behaviour of the Ad-Free notification appears normal; it's shows the blocking and mute sign when it mute, and neck to normal when the blocking stops; but it just stops a bit early sometimes.

[abertschi]

If the behavior is irregular, there is not much I can do. I was thinking of adding an option to delay the action of unmuting. But this option will be applied for all unmutes, as there is no obvious way to recognize when to unmute and when to delay before unmute.

Currently, once one of the ad-detectors recognizes that there is no more ad playing, ad-free will unmute the stream audio channel and hide its notification.

ad-free/app/src/main/java/ch/abertschi/adfree/AdStateController.kt

Lines 75 to 83 in 9232901

	fun onNoAd(observable: AdObservable) {
	info { "AdEvent Change: NO_ADD" }
	activeState = EventType.NO_AD
	adPluginHandler.stopPlugin {
	notificationChannel.hideDefaultAdNotification()
	audioController.unmuteMusicStream()
	}
	}

[roadie]

Thanks for your attention. To be honest, I think the delay unmute option would still be quite helpful because although it's irregular, most of the ads are played for a second at the end. If the option is there, then those who has similar problem can use it. I would set it to one or two seconds still and cut out the ads, if it sacrifices the first second or two of the next song, I think it's still a good trade-off. At the same time, is there anything else you could suggest to troubleshoot so I can find the root cause of this problem?

…

On Tue, Oct 8, 2019 at 9:50 AM Andrin Bertschi ***@***.***> wrote: If the behavior is irregular, there is not much I can do. I was thinking of adding an option to delay the action of unmuting. But this option will be applied for all unmutes, as there is no obvious way to recognize when to unmute and when to delay before unmute. Currently, once one of the ad-detectors recognizes that there is no more ad playing, ad-free will unmute the stream audio channel and hide its notification. https://github.com/abertschi/ad-free/blob/92329012918c492c5349efc2e2000c0da773bc0b/app/src/main/java/ch/abertschi/adfree/AdStateController.kt#L75-L83 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#39?email_source=notifications&email_token=AGXQ54XCI4ZWR33HXLZDUJLQNS267A5CNFSM4I3TMKZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAU3JEY#issuecomment-539604115>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGXQ54UHRU7BGWUB7MUIZW3QNS267ANCNFSM4I3TMKZA> .

[abertschi]

At the same time, is there anything else you could suggest to
troubleshoot so I can find the root cause of this problem?

The only thing on top of my head is Settings/Playback/Crossfade option in the Spotify app, did you enable it? It may cause some interference with the notifications. If so, disable it.

[roadie]

Thanks for the suggestion. The settings in Spotify should be all in default mode, but I checked; the crossfade is off, Gapless is off. There's an option called Automix and it's on. Don't know what it is, but what I'll do is to turn it off and see if it makes any difference. Will report back. Thanks.

…

On Tue, Oct 8, 2019 at 10:11 AM Andrin Bertschi ***@***.***> wrote: At the same time, is there anything else you could suggest to troubleshoot so I can find the root cause of this problem? The only thing on top of my head is Settings/Playback/Crossfade option in the Spotify app, did you enable it? It may cause some interference with the notifications. If so, disable it. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#39?email_source=notifications&email_token=AGXQ54QDSBHQKM4WGWJTKVTQNS5KTA5CNFSM4I3TMKZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAU5IKI#issuecomment-539612201>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGXQ54UKJGRGBXHSNRT73FDQNS5KTANCNFSM4I3TMKZA> .

[abertschi]

fixed in version #52