Multiple accounts #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
papaharry
reviewed
Dec 24, 2024
| } | ||
| let unreadCount; | ||
|
|
||
| function getUnreadCount(doc) { |
There was a problem hiding this comment.
I have submitted an other PR where I am changing this function to be based on entry due to an issue with full count and categories/pre defined labels.
Have a look here in case we can combine the PRs.
Having said that, I am not the owner of the repo/extension, so not sure if that's acceptable overall in regards to changing the function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for multiple Gmail accounts. In
updateBadgeIconwe loop through up to 10 atomfeed accounts (logged in Google accounts) and tally up the unread count.Changed the polling interval to 10 sec, because it felt fast enough and it feels fairly expensive to poll more frequently. Probably should move polling interval to an optional user config, if someone wants to add that feature.