Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make multipart_form public #298

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Conversation

omarabid
Copy link
Contributor

@omarabid omarabid commented Dec 8, 2024

I am implementing a custom connector and this module is necessary in order to implement the connector trait (unless I am doing something wrong?).

This function in particular

    fn http_post_uri_multipart_form<'a, 'p, RS, PT, TS>(
        &'a self,
        full_uri: Url,
        file: Option<FileMultipartData<'p>>,
        params: &'p PT,
        context: SlackClientApiCallContext<'a>,
    ) -> BoxFuture<'a, ClientResult<RS>>

FileMultipartData itself is declared public. However, it is inaccessible behind the private module. Another solution is to re-export it as public.

Copy link
Owner

@abdolence abdolence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I have no objections to make it visible if it useful.

@abdolence abdolence merged commit 996ab88 into abdolence:master Dec 9, 2024
2 checks passed
@omarabid
Copy link
Contributor Author

Thanks for the quick release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants