Publish fields in SlackFile struct #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, definitely. I've added them recently, probably nobody are using them 🙈 |
bmalicoat
pushed a commit
to bmalicoat/slack-morphism-rust
that referenced
this pull request
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fields in many structs in models crate, excepting
SlackFileis currently public and can be accessed from other crates. In addition,SlackMessageContentstruct has afilesfield of typeOption<Vec<SlackFile>>, which is public. Thus, we cannot read files from this field across crates due to the missing visibility specifier.This pull request proposes to add
pub-s to fields inSlackFilestruct, like other many-many structs.