Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making instanceTerminationAction for Compute Engine API nullable #143

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Making instanceTerminationAction for Compute Engine API nullable #143

merged 1 commit into from
Jun 17, 2024

Conversation

abdolence
Copy link
Owner

No description provided.

@abdolence abdolence linked an issue Jun 6, 2024 that may be closed by this pull request
Cannot create a standard instance from a spot machine image because serde skips serializing instance_termination_action #141
Closed
@abdolence abdolence mentioned this pull request Jun 6, 2024
Closed
Nereuxofficial
Nereuxofficial approved these changes Jun 10, 2024
View reviewed changes
Copy link

@Nereuxofficial Nereuxofficial left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the timely fix! I tried it and it works flawlessly

Is there any way to get GCP to fix the openapi.yaml file they provide?

@abdolence
Copy link
Owner Author

Thanks for testing it.
I'm not sure if those specs can be changed. For now I'll keep patch on my side.

@abdolence abdolence merged commit 5b8ef6a into master Jun 17, 2024
1 check passed
@abdolence abdolence deleted the fix/nullable-instance-termination-action branch June 17, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nereuxofficial Nereuxofficial Nereuxofficial approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@abdolence @Nereuxofficial