Using SqlServerCondition.SupportsFunctions2022 for LTRIM and RTRIM. H…

…andling compatibility level to low.
abdielcs · May 16, 2024 · e1a73e7 · e1a73e7
1 parent 4448f35
commit e1a73e7
Show file tree

Hide file tree

Showing 4 changed files with 32 additions and 4 deletions.
diff --git a/src/EFCore.SqlServer/Properties/SqlServerStrings.Designer.cs b/src/EFCore.SqlServer/Properties/SqlServerStrings.Designer.cs
diff --git a/src/EFCore.SqlServer/Properties/SqlServerStrings.resx b/src/EFCore.SqlServer/Properties/SqlServerStrings.resx
@@ -362,4 +362,7 @@
   <data name="TransientExceptionDetected" xml:space="preserve">
     <value>An exception has been raised that is likely due to a transient failure. Consider enabling transient error resiliency by adding 'EnableRetryOnFailure' to the 'UseSqlServer' call.</value>
   </data>
+  <data name="TrimStartTrimEndWithArgsCompatibilityLevelTooLow" xml:space="preserve">
+    <value>EF Core's SQL Server compatibility level is set to {compatibilityLevel}; compatibility level 160 (SQL Server 2022) is the minimum for functions LTRIM and RTRIM with the optional characters positional argument.</value>
+  </data>
 </root>
diff --git a/src/EFCore.SqlServer/Query/Internal/SqlServerStringMethodTranslator.cs b/src/EFCore.SqlServer/Query/Internal/SqlServerStringMethodTranslator.cs
@@ -3,6 +3,7 @@
 
 using Microsoft.EntityFrameworkCore.Query.SqlExpressions;
 using Microsoft.EntityFrameworkCore.SqlServer.Infrastructure.Internal;
+using Microsoft.EntityFrameworkCore.SqlServer.Internal;
 using ExpressionExtensions = Microsoft.EntityFrameworkCore.Query.ExpressionExtensions;
 
 namespace Microsoft.EntityFrameworkCore.SqlServer.Query.Internal;
@@ -205,7 +206,7 @@ public SqlServerStringMethodTranslator(ISqlExpressionFactory sqlExpressionFactor
             }
 
             if (TrimStartMethodInfoWithCharArg.Equals(method)
-                && _sqlServerSingletonOptions.CompatibilityLevel >= 160)
+                && CheckTrimStartTrimEndWithArgsCompatibilityLevel())
             {
                 return _sqlExpressionFactory.Function(
                     "LTRIM",
@@ -217,7 +218,7 @@ public SqlServerStringMethodTranslator(ISqlExpressionFactory sqlExpressionFactor
             }
 
             if (TrimStartMethodInfoWithCharArrayArg.Equals(method)
-                && _sqlServerSingletonOptions.CompatibilityLevel >= 160)
+                && CheckTrimStartTrimEndWithArgsCompatibilityLevel())
             {
                 var firstArgumentValue = (arguments[0] as SqlConstantExpression)?.Value as char[];
                 var firstArgument = _sqlExpressionFactory.Constant(new string(firstArgumentValue), instance.TypeMapping);
@@ -246,7 +247,7 @@ public SqlServerStringMethodTranslator(ISqlExpressionFactory sqlExpressionFactor
 
 
             if (TrimEndMethodInfoWithCharArg.Equals(method)
-                && _sqlServerSingletonOptions.CompatibilityLevel >= 160)
+                && CheckTrimStartTrimEndWithArgsCompatibilityLevel())
             {
                 return _sqlExpressionFactory.Function(
                     "RTRIM",
@@ -258,7 +259,7 @@ public SqlServerStringMethodTranslator(ISqlExpressionFactory sqlExpressionFactor
             }
 
             if (TrimEndMethodInfoWithCharArrayArg.Equals(method)
-                && _sqlServerSingletonOptions.CompatibilityLevel >= 160)
+                && CheckTrimStartTrimEndWithArgsCompatibilityLevel())
             {
                 var firstArgumentValue = (arguments[0] as SqlConstantExpression)?.Value as char[];
                 var firstArgument = _sqlExpressionFactory.Constant(new string(firstArgumentValue), instance.TypeMapping);
@@ -421,4 +422,16 @@ private SqlExpression TranslateIndexOf(
             },
             charIndexExpression);
     }
+
+    private bool CheckTrimStartTrimEndWithArgsCompatibilityLevel()
+        => CheckCompatibilityLevel(160, SqlServerStrings.TrimStartTrimEndWithArgsCompatibilityLevelTooLow);
+
+    private bool CheckCompatibilityLevel(int compatibilityLevel, Func<object?, string> compatibilityTooLowFunction)
+    {
+        if (_sqlServerSingletonOptions.CompatibilityLevel < compatibilityLevel)
+        {
+            throw new InvalidOperationException(compatibilityTooLowFunction(compatibilityLevel));
+        }
+        return true;
+    }
 }
diff --git a/test/EFCore.SqlServer.FunctionalTests/Query/NorthwindFunctionsQuerySqlServerTest.cs b/test/EFCore.SqlServer.FunctionalTests/Query/NorthwindFunctionsQuerySqlServerTest.cs
@@ -2540,6 +2540,7 @@ WHERE LTRIM([c].[ContactTitle]) = N'Owner'
 """);
     }
 
+    [SqlServerCondition(SqlServerCondition.SupportsFunctions2022)]
     public override async Task TrimStart_with_char_argument_in_predicate(bool async)
     {
         await base.TrimStart_with_char_argument_in_predicate(async);
@@ -2552,6 +2553,7 @@ WHERE LTRIM([c].[ContactTitle], N'O') = N'wner'
 """);
     }
 
+    [SqlServerCondition(SqlServerCondition.SupportsFunctions2022)]
     public override async Task TrimStart_with_char_array_argument_in_predicate(bool async)
     {
         await base.TrimStart_with_char_array_argument_in_predicate(async);
@@ -2576,6 +2578,7 @@ WHERE RTRIM([c].[ContactTitle]) = N'Owner'
 """);
     }
 
+    [SqlServerCondition(SqlServerCondition.SupportsFunctions2022)]
     public override async Task TrimEnd_with_char_argument_in_predicate(bool async)
     {
         await  base.TrimEnd_with_char_argument_in_predicate(async);
@@ -2588,6 +2591,7 @@ WHERE RTRIM([c].[ContactTitle], N'r') = N'Owne'
 """);
     }
 
+    [SqlServerCondition(SqlServerCondition.SupportsFunctions2022)]
     public override async Task TrimEnd_with_char_array_argument_in_predicate(bool async)
     {
         await base.TrimEnd_with_char_array_argument_in_predicate(async);