Add general purpose HTML and JSON rendering package #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethvargo
requested review from
a team,
verbanicm,
mattrandallbecker,
pdewilde and
lock14
shankiyani
reviewed
Mar 3, 2023
sethvargo
force-pushed
the
sethvargo/render
branch
from
dc65834 to
6dff86d
Compare
shankiyani
approved these changes
Mar 3, 2023
sethvargo
force-pushed
the
sethvargo/render
branch
from
6dff86d to
6214ced
Compare
This brings over a bunch of the high-performance and highly-fault-tolerant HTML and JSON rendering from Exposure Notifications, but decouples it from the EN internals. Of note: - It does not have a dependency on a specific logger and instead allows providing an `onError` handler; there are no dependencies besides the stdlib. - Reasonable set of built-in functions with the ability to append custom ones. The package-level comment provides more details and there are some examples of how the package can be used in renderer_test.go.
sethvargo
force-pushed
the
sethvargo/render
branch
from
6214ced to
ac9ce65
Compare
|
Thanks for doing this 🙌 |
Yup - I'll write it up to the JVS once I get reviews from other folks. Since it's pretty big, I requested some extra eyes 😄. |
verbanicm
reviewed
Mar 3, 2023
verbanicm
reviewed
Mar 3, 2023
verbanicm
approved these changes
Mar 3, 2023
verbanicm
reviewed
Mar 3, 2023
|
How does this compare to https://pkg.go.dev/html/template ? |
|
@pdewilde it uses that package internally. |
sethvargo
added a commit
to abcxyz/jvs
that referenced
this pull request
Mar 3, 2023
github.com/abcxyz/pkg#73 ported the renderer from this project into pkg. This moves jvs to use the pkg renderer.
sethvargo
added a commit
to abcxyz/jvs
that referenced
this pull request
Mar 3, 2023
github.com/abcxyz/pkg#73 ported the renderer from this project into pkg. This moves jvs to use the pkg renderer.
sethvargo
added a commit
to abcxyz/jvs
that referenced
this pull request
Mar 4, 2023
github.com/abcxyz/pkg#73 ported the renderer from this project into pkg. This moves jvs to use the pkg renderer.
sethvargo
added a commit
to abcxyz/jvs
that referenced
this pull request
Mar 5, 2023
github.com/abcxyz/pkg#73 ported the renderer from this project into pkg. This moves jvs to use the pkg renderer.
sqin2019
pushed a commit
to abcxyz/jvs
that referenced
this pull request
Apr 6, 2023
github.com/abcxyz/pkg#73 ported the renderer from this project into pkg. This moves jvs to use the pkg renderer.
sethvargo
added a commit
that referenced
this pull request
Jun 13, 2023
* Add general purpose HTML and JSON rendering package This brings over a bunch of the high-performance and highly-fault-tolerant HTML and JSON rendering from Exposure Notifications, but decouples it from the EN internals. Of note: - It does not have a dependency on a specific logger and instead allows providing an `onError` handler; there are no dependencies besides the stdlib. - Reasonable set of built-in functions with the ability to append custom ones. The package-level comment provides more details and there are some examples of how the package can be used in renderer_test.go. * Process review feedback
verbanicm
pushed a commit
to abcxyz/jvs
that referenced
this pull request
Jun 14, 2023
github.com/abcxyz/pkg#73 ported the renderer from this project into pkg. This moves jvs to use the pkg renderer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings over a bunch of the high-performance and highly-fault-tolerant HTML and JSON rendering from Exposure Notifications, but decouples it from the EN internals. Of note:
onErrorhandler; there are no dependencies besides the stdlib.The package-level comment provides more details and there are some examples of how the package can be used in renderer_test.go.