Fix load-workflow-variables issue where config file cannot be found #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjonathanhong
requested review from
Celdir,
sailorlqh and
verbanicm
and removed request for
Celdir and
sailorlqh
sethvargo
approved these changes
Sep 27, 2024
Merged
token-minter-prod bot
added a commit
that referenced
this pull request
Sep 27, 2024
## What's Changed * fix: load workflow variables by @verbanicm in #347 * Fix load-workflow-variables issue where config file cannot be found by @gjonathanhong in #348 **Full Changelog**: v1.1.3...v1.1.4 Co-authored-by: token-minter-prod[bot] <125072751+token-minter-prod[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the
./prefix from the input filepath before passing the value onto the following steps. If./guardian.ymlis provided, then this will be sanitized toguardian.yml.This fixes an issue with
load-workflow-variablesaction caused by providing a relative path forinputs.filepath, e.g../guardian.ymlinstead ofguardian.yml. Passing this value to thesparse-checkoutoption of the Checkout step caused the action to not match with theguardian.ymlfile at the root of the repository, resulting in a file not found error in theLoad Workflow Variablesstep.