fix: performance of want_lgtm_all #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradegler
reviewed
Apr 16, 2024
verbanicm
force-pushed
the
verbanicm/fix
branch
from
9d26c68 to
2f07cad
Compare
bradegler
approved these changes
Apr 16, 2024
sethvargo
approved these changes
Apr 16, 2024
Merged
token-minter-prod bot
added a commit
that referenced
this pull request
Jun 14, 2024
## What's Changed * Upgrade golangci to disable loopvar in Go 1.22 by @sethvargo in #314 * dont enforce static message for sloglint by @shankiyani in #316 * Add generic helpers for pointers by @sethvargo in #317 * Add wf names to README.md examples by @pdewilde in #319 * terraformlint: fix typo in error message by @sethvargo in #318 * Update README.md for want_lgtm_all to add required status check setp by @pdewilde in #320 * RELEASING.md release process documentation by @pdewilde in #322 * fix: unable to create lightweighted tag by @sqin2019 in #324 * fix: performance of want_lgtm_all by @verbanicm in #326 * build(deps): bump golang.org/x/net from 0.22.0 to 0.23.0 in the go_modules group across 1 directory by @dependabot in #327 * Update deps by @sethvargo in #328 * Expand githubauth to pull installation IDs given an org, repo, or user by @sethvargo in #330 * Fix pointer receiver name by @sethvargo in #332 **Full Changelog**: v1.0.4...v1.1.0 Co-authored-by: token-minter-prod[bot] <125072751+token-minter-prod[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
containsexpression is not case sensitive which allows this to work, saving a job run and an API call detailseditedstatus for the review comment only triggers when a review comment body is updated, so it is not needed.WANT_LGTM=all