feat: add draft prs to create-pull-request #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethvargo
approved these changes
Feb 20, 2024
Merged
token-minter-prod bot
added a commit
that referenced
this pull request
Mar 5, 2024
## What's Changed * feat: add draft prs to create-pull-request by @verbanicm in #303 * Add cleanup scripts by @sethvargo in #289 * Fix race with using DefaultLogger by @sethvargo in #304 * fix: release by @verbanicm in #305 * Switch to nicer quoting for YAML conditions by @sethvargo in #306 * Remove some double-quoting in workflows by @sethvargo in #307 * Disable caching on golangci by @sethvargo in #308 * Update to new release process by @sethvargo in #309 * Update deps and Go version by @sethvargo in #311 **Full Changelog**: v1.0.3...v1.0.4 Co-authored-by: token-minter-prod[bot] <125072751+token-minter-prod[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change add the ability to create pull requests in draft status.
This change also modifies the existing logic to enable auto merge.
Since both draft and auto-merge are binary states, this change allows the user to toggle the status when creating/updating the pull request and the actions will safely modify.
I ran into several issues with using github-script and the API, namely we have to do a bunch of additional validation against existing states, where the gh cli already does this. I opted for the CLI to not re-invent the wheel and allow for somewhat "cleaner" code.