githubauth: fix response parsing #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethvargo
force-pushed
the
sethvargo/app
branch
from
b7a6c6b to
fc646e9
Compare
This fixes a bug where the TokenSource would return the correct value, but the direct invocations would fail.
sethvargo
force-pushed
the
sethvargo/app
branch
2 times, most recently
from
f3fa8fb to
2d4fec8
Compare
sethvargo
force-pushed
the
sethvargo/app
branch
from
2d4fec8 to
8061212
Compare
verbanicm
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where the TokenSource would return the correct value, but the direct invocations would fail.
This is affecting the latest Minty release.
Review the first commit for the nicer diff. The second commit is moving things around so this mistake doesn't happen again: 1dc001b.