-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make LookupEnv
use cached v
parameter
#280
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is actually intentional; we don't lock, so we want to create the local allocation in case the underlying variables changes beneath us. You cannot guarantee that the c.stdout
on L1 is the same c.stdout
that you return.
Oops, that wasn't the "delete draft button" |
32fc2b3
to
fe85f0f
Compare
fe85f0f
to
4cf5ff6
Compare
I see, that makes sense. Shouldn't |
LookupEnv
use cached v parameter
LookupEnv
use cached v parameterLookupEnv
use cached v
parameter
No description provided.