-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4.0 release candidate #31
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
drzax
commented
Sep 28, 2020
- Create a shared graphic component for the examples
- Tighter type definitions
- Better separation between CM utils and the component
- Return more data from the onProgress hook
- Support for theme, waypoint and graphicinfront config from CM tags
- Better separation between config and data on the #marks
- Update examples
- Update readme
This commit does a bunch of stuff - Tighter type definitions - Better separation between CM utils and the component - Return more data from the onProgress hook - Support for theme, waypoint and graphicinfront config from CM tags - Better separation between config and data on the #marks
size-limit report
|
phocks
approved these changes
Sep 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good to me
Going to merge this and release 4.0 today unless I hear any objections. |
What happened to version 3? |
There's already a version 3 on npm. Not sure why it's not listed under
releases here.
…On Tue, 29 Sep 2020 at 01:16, Joshua Byrd ***@***.***> wrote:
What happened to version 3?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#31 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAERUU7GYJPGCBYVFFY4FU3SIEYOZANCNFSM4R4BCX6A>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.