Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.0 release candidate #31

Merged
merged 9 commits into from
Oct 1, 2020
Merged

4.0 release candidate #31

merged 9 commits into from
Oct 1, 2020

Conversation

drzax
Copy link
Member

@drzax drzax commented Sep 28, 2020

  • Create a shared graphic component for the examples
  • Tighter type definitions
  • Better separation between CM utils and the component
  • Return more data from the onProgress hook
  • Support for theme, waypoint and graphicinfront config from CM tags
  • Better separation between config and data on the #marks
  • Update examples
  • Update readme

This commit does a bunch of stuff
- Tighter type definitions
- Better separation between CM utils and the component
- Return more data from the onProgress hook
- Support for theme, waypoint and graphicinfront config from CM tags
- Better separation between config and data on the #marks
@github-actions
Copy link

github-actions bot commented Sep 28, 2020

size-limit report

Path Size
dist/scrollyteller.cjs.production.min.js 3.82 KB (+3.15% 🔺)
dist/scrollyteller.esm.js 3.74 KB (+3.37% 🔺)

Copy link
Member

@phocks phocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good to me

@drzax
Copy link
Member Author

drzax commented Sep 29, 2020

Going to merge this and release 4.0 today unless I hear any objections.

@phocks
Copy link
Member

phocks commented Sep 29, 2020

What happened to version 3?

@drzax
Copy link
Member Author

drzax commented Sep 29, 2020 via email

@drzax drzax merged commit 14addf0 into master Oct 1, 2020
@drzax drzax deleted the development branch October 1, 2020 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants