Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with Laravel 11 #6

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Conversation

sharafat
Copy link
Contributor

@sharafat sharafat commented Apr 16, 2024

This is still failing with the following error, however:

Problem 1 - Root composer.json requires abbasudo/pulse-users dev-patch-1 -> satisfiable by abbasudo/pulse-users[dev-patch-1]. - abbasudo/pulse-users dev-patch-1 requires illuminate/contracts ^10.21|^11.4 -> satisfiable by illuminate/contracts[v10.21.0, ..., 10.x-dev, v11.4.0, 11.x-dev]. - Only one of these can be installed: illuminate/contracts[dev-master, v5.0.0, ..., 5.8.x-dev, v6.0.0, ..., 6.x-dev, v7.0.0, ..., 7.x-dev, v8.0.0, ..., 8.x-dev, v9.0.0-beta.1, ..., 9.x-dev, v10.0.0, ..., 10.x-dev, v11.0.0, ..., 11.x-dev], laravel/framework[v11.3.1]. laravel/framework replaces illuminate/contracts and thus cannot coexist with it. - Root composer.json requires laravel/framework 11.3.1 -> satisfiable by laravel/framework[v11.3.1].

I guess for L11 compatibility we have a couple of choices:

  1. Replace illuminate/contracts with laravel/framework version ^10.0|^11.0
  2. Have a separate branch with illuminate/contracts removed from package.json

Which one is better?

@abbasudo abbasudo merged commit 5daed67 into abbasudo:master Apr 17, 2024
Copy link
Owner

@abbasudo abbasudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants