Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local album art doesn't load unless I open the album #851

Open
stephen304 opened this issue Dec 30, 2017 · 9 comments
Open

Local album art doesn't load unless I open the album #851

stephen304 opened this issue Dec 30, 2017 · 9 comments

Comments

@stephen304
Copy link

I have MPD + Nginx running with a colection of music that all has embedded album art and folder.jpg in the album folders.

The problem is that no album art shows unles I press on the album, after which it loads and going back to the album view shows the art. It seems to automatically request art from online providers when scrolling through the list, but it doesn't seem to to this when using local art.

@abarisain
Copy link
Owner

Pretty sure it's an old limitation of the MPD protocol.

For local cover art, MPDroid needs the file path, and that's not available until you open an album, where MPDroid uses the first tracks's path (after all, an album can be in multiple folders)

I don't know if the protocol has been updated to allow me to fix this

@stephen304
Copy link
Author

stephen304 commented Dec 31, 2017 via email

@stephen304
Copy link
Author

Actually I just found out that the app already supports auto fetching the album art - it just relies on having the MPD database cached via the option Settings > Library Settings > Use Album Cache.

Maybe it should have a note below that option mentioning the loading of album images.

@abarisain
Copy link
Owner

To be fair, MPDroid isn't actively developed anymore.

I do know that the album cache suffers from some bugs

@stephen304
Copy link
Author

I could tell it wasn't very active. Though I like to file bugs anyways in case someone with time and energy comes along.

In this case I don't think there's any real bug, just wording and documentation that could be improved. So if I come up with any wording change for the app, I'll make a PR. And I may make a note in the wiki about enabling MPD database cache.

@hurzl
Copy link
Contributor

hurzl commented Jan 1, 2018

I always thought the album cache should be enabled by default. I never had problems with it.

@abarisain
Copy link
Owner

I think the max command size issue (when not configured in mpd) prevented us to ship it by default?

Anyway, documentation is welcome, but I doubt I'll release a new version of the app even if you kindly send a PR for that

@hurzl
Copy link
Contributor

hurzl commented Jan 1, 2018

Maybe it was max_output_buffer_size (for all albums list?) - the only value I have set in mpd.conf.

@abarisain
Copy link
Owner

That's it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants