Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add wine, rcedit, update to focal #37

Closed
wants to merge 2 commits into from
Closed

add wine, rcedit, update to focal #37

wants to merge 2 commits into from

Conversation

monban
Copy link

@monban monban commented Oct 23, 2020

This PR does the following:

  • Updates Ubuntu to focal, by using the latest version of git we can use the Checkout action v2
  • Installs wine, this is required to use rcedit
  • Downloads rcedit to /usr/loca/bin, required to change / correct the icon on build Windows executables
  • Makes downloads quiet, less spam in the build log

Contributor Edit:
Fixes #21

@realkotob realkotob added the enhancement New feature or request label Oct 24, 2020
Dockerfile Outdated Show resolved Hide resolved
@monban
Copy link
Author

monban commented Oct 24, 2020

As per the conversation above, I've changed --quiet to --no-verbose. Also I'm wondering if it would be a good idea to document somewhere as to how to use rcedit? Here is roughly what I'm doing on github actions:

      - name: Setup
        run: |
          chown -R root:root $HOME
          mkdir -v -p ~/.local/share/godot/templates
          mv /root/.local/share/godot/templates/${GODOT_VERSION}.stable ~/.local/share/godot/templates/${GODOT_VERSION}.stable
      - name: Windows Desktop Build
        run: |
          mkdir -v -p $GITHUB_WORKSPACE/build/windows-desktop
          cd $GITHUB_WORKSPACE/src
          godot -v --export "Windows Desktop" $GITHUB_WORKSPACE/build/windows-desktop/$EXPORT_NAME.exe
      - name: Convert png to ico
        run: convert $GITHUB_WORKSPACE/src/assets/common/textures/icons/icon.png -define icon:auto-resize="256,128,96,64,48,32,16" ~/icon.ico
      - name: Change exe icon
        run: cd $GITHUB_WORKSPACE; wine $GITHUB_WORKSPACE/rcedit.exe $GITHUB_WORKSPACE/build/windows-desktop/$EXPORT_NAME.exe --set-icon ~/icon.ico

In any event, please re-review and let me know if I can help by touching up the documentation anywhere.

@monban monban requested a review from realkotob October 24, 2020 23:05
@realkotob
Copy link
Collaborator

realkotob commented Oct 25, 2020

@monban If you'd like you can add a note at the bottom of README on how to use it, and/or a comment to the gitlab and github config scripts.

@abarichello
Copy link
Owner

abarichello commented Oct 27, 2020

Copy link
Owner

@abarichello abarichello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @asheraryam, a short 'how to use rcedit' section in the readme would be helpful

@abarichello
Copy link
Owner

Using wine for the rcedit with GitHub actions is failing with this error message:
wine: '/__w/godot-ci/godot-ci' is not owned by you, refusing to create a configuration directory there
Action log: https://github.com/aBARICHELLO/godot-ci/runs/1371907817?check_suite_focus=true

Also act is giving me different results locally, testing this is a real pain.

@monban
Copy link
Author

monban commented Nov 9, 2020

Yeah, unfortunately you need to chown the home directory when running from GithubActions, here is an example of usage, (note the chown on line 30) I've been trying to figure out if there is a better way to accomplish this, hence why I haven't created the above referenced documentation yet...

@2shady4u
Copy link
Contributor

@monban do you have any updates on this?

@monban
Copy link
Author

monban commented Apr 19, 2021

You know what, I completely forgot about this, I'm sorry. I'll get on this after work today, expect an update in the next couple of hours.

@Deozaan
Copy link

Deozaan commented Nov 8, 2021

This looks really useful. Is there any chance of this getting updated and merged? @monban

@realkotob
Copy link
Collaborator

@Deozaan If you are interesting in picking this up feel free to open a new PR with the changes.

@Deozaan
Copy link

Deozaan commented Jan 4, 2023

If you are interesting in picking this up feel free to open a new PR with the changes.

I've looked into it briefly and I think it's beyond my skill level. 😳😬

@monban
Copy link
Author

monban commented Mar 19, 2023

At this point I no longer recommend people to use rcedit, but rather to use Godot Icon instead.

@monban monban closed this Mar 19, 2023
@Calinou
Copy link
Collaborator

Calinou commented Jul 13, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include rcedit for Windows builds
6 participants