-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add wine, rcedit, update to focal #37
Conversation
As per the conversation above, I've changed
In any event, please re-review and let me know if I can help by touching up the documentation anywhere. |
@monban If you'd like you can add a note at the bottom of README on how to use it, and/or a comment to the gitlab and github config scripts. |
Pipelines are working |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @asheraryam, a short 'how to use rcedit' section in the readme would be helpful
Using wine for the rcedit with GitHub actions is failing with this error message: Also act is giving me different results locally, testing this is a real pain. |
Yeah, unfortunately you need to chown the home directory when running from GithubActions, here is an example of usage, (note the chown on line 30) I've been trying to figure out if there is a better way to accomplish this, hence why I haven't created the above referenced documentation yet... |
@monban do you have any updates on this? |
You know what, I completely forgot about this, I'm sorry. I'll get on this after work today, expect an update in the next couple of hours. |
This looks really useful. Is there any chance of this getting updated and merged? @monban |
@Deozaan If you are interesting in picking this up feel free to open a new PR with the changes. |
I've looked into it briefly and I think it's beyond my skill level. 😳😬 |
At this point I no longer recommend people to use rcedit, but rather to use Godot Icon instead. |
|
This PR does the following:
Contributor Edit:
Fixes #21