Skip to content

Commit

Permalink
ui: small fixes to DB Console charts shown for secondary tenants
Browse files Browse the repository at this point in the history
cockroachdb#97995 updated the
DB Console to filter out KV-specific charts from the metrics page
when viewing DB Console as a secondary application tenant.

The PR missed a couple small details. This patch cleans those
up with the following:

- Removes KV latency charts for app tenants
- Adds a single storage graph for app tenants showing livebytes
- Removes the "Capacity" chart on the Overview dashboard for app
  tenants

Release note: none
  • Loading branch information
abarganier committed Apr 4, 2023
1 parent 4dd0304 commit c691159
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ export default function (props: GraphDashboardProps) {

<LineGraph
title="Capacity"
isKvGraph={false}
isKvGraph={true}
sources={storeSources}
tooltip={<CapacityGraphTooltip tooltipSelection={tooltipSelection} />}
preCalcGraphSize={true}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,7 @@ export default function (props: GraphDashboardProps) {

<LineGraph
title="KV Execution Latency: 99th percentile"
isKvGraph={false}
isKvGraph={true}
tooltip={`The 99th percentile of latency between query requests and responses over a
1 minute period. Values are displayed individually for each node.`}
>
Expand All @@ -350,7 +350,7 @@ export default function (props: GraphDashboardProps) {

<LineGraph
title="KV Execution Latency: 90th percentile"
isKvGraph={false}
isKvGraph={true}
tooltip={`The 90th percentile of latency between query requests and responses over a
1 minute period. Values are displayed individually for each node.`}
>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ export default function (props: GraphDashboardProps) {

<LineGraph
title="Live Bytes"
isKvGraph={false}
sources={storeSources}
tooltip={<LiveBytesGraphTooltip tooltipSelection={tooltipSelection} />}
>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ const dashboards: { [key: string]: GraphDashboard } = {
storage: {
label: "Storage",
component: storageDashboard,
isKvDashboard: true,
isKvDashboard: false,
},
replication: {
label: "Replication",
Expand Down

0 comments on commit c691159

Please sign in to comment.