Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
changefeedccl: deflake TestAlterChangefeedAddTargetsDuringBackfill
Note this commit is similar to 1295da9, but applies to a different test. Previously, this test failed because of the maximum allowed checkpoint frequency being too low (every 10ms). This test fails consistently when the frequency lower (ex. every 500ms) and fails very, very rarely when the frequency is 10ms. To fix these rare flakes, this change sets the frequency to once every nanosecond, which is the higest possible frequency value since setting 0 will disable checkpointing. The reason the test fails with a large frequency is as follows: The test waits to observe a checkpoint during a schema change backfill. Because the changefeed is running normally before the schema change and backfill occurs, it is regularly checkpointing the highwater. Thus, it's possible for the changefeed to checkpoint the highwater, then complete the entire backfill without checkpointing within 10ms. No checkpoints will be written during the backfill in that scenario because 10ms have not passed since the last checkpoint. In this scenario, the test fails to see a checkpoint written during the backfill and times out. Fixes: cockroachdb#110796 Release note: None Epic: None Please enter a valid issue or epic reference:
- Loading branch information