Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

https://github.com/abapGit/ADT_Frontend/issues/92 #94

Closed
wants to merge 2 commits into from

Conversation

andau
Copy link

@andau andau commented Dec 3, 2018

First draft of project explorer integration, maybe a bit different like suggested in the issue above.

The visibility of the two menu items is actually not ideal (currently the menu items are shown for ABAP projects but also for standard projects - did recognize this after creation of the pull request). Thus the IProject part has to be removed. The visibility part is currently duplicated three times, but I did not refactored it already as I am not sure if the visibility is not differently wanted (eg. only when an ABAP package is selected).

If this type of integration into the project explorer is desired then a possible next step would be to get the project and package into the AbapGitPull action for example, I would do this by adding the plugin com.sap.adt.projectexplorer to the project.

But I leave it for the moment like it is, until its clear whether this pull request fits into the overall design of this project or not.

Let me know, Andreas

Copy link
Member

@larshp larshp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the examples, will try it

@larshp
Copy link
Member

larshp commented Dec 4, 2018

@andau can you help by adding some screenshots?

@andau
Copy link
Author

andau commented Dec 6, 2018

well currently there is not much to cover with screenshots, there are only 2 new menu items:

  • the first one opens the yet existing view of the repositories
  • and the second menu items provides a draft for example for a pull command.

@larshp
Copy link
Member

larshp commented Dec 7, 2018

I'm just trying to be lazy, starting up Eclipse for everyone looking at this PR takes time, while a screenshot gives a good overview of the feature/change without any effort for the peers

@andau
Copy link
Author

andau commented Dec 9, 2018

Here an animated gif with the current functionality. As mentioned before its not yet completed as I want to be lazy too in the case it does not fit to the target design.

abapgit_project_explorer

@larshp
Copy link
Member

larshp commented Dec 20, 2018

#92

@larshp
Copy link
Member

larshp commented Dec 20, 2018

@andau thanks, good examples

however closing PR, see mockup in #92

@larshp larshp closed this Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants