fix: add checks for peripheral.mtu #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 24, 2021
rzr
reviewed
Feb 9, 2021
| @@ -569,7 +569,7 @@ Noble.prototype.onHandleNotify = function (peripheralUuid, handle, data) { | |||
|
|
|||
| Noble.prototype.onMtu = function (peripheralUuid, mtu) { | |||
| var peripheral = this._peripherals[peripheralUuid]; | |||
| peripheral.mtu = mtu; | |||
| if (peripheral && peripheral.mtu && mtu) peripheral.mtu = mtu; | |||
There was a problem hiding this comment.
or maybe : var peripheral = this._peripherals[peripheralUuid] || {} ?
There was a problem hiding this comment.
or maybe : var peripheral = this._peripherals[peripheralUuid] || {} ?
if peripheral = {} then peripheral.mtu will get TypeError i guess? same for if (peripheral) when accessing .mtu
There was a problem hiding this comment.
if peripheral = {} then peripheral.mtu is undefined but you can do affectation:
``
node
Welcome to Node.js v14.15.0.
Type ".help" for more information.
var p = {};
undefined
p.foo = true;
true
console.log( p.as)
undefined
|
please rebase |
|
can you please try to update your branch ? |
checks if it's valid when setting it. Should fix the TypeError of it
|
@rzr sry for the late reply just rebased it |
mylylyl
commented
Mar 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
checks if it's valid when setting it.
Should fix the TypeError of it