Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

npm: Pin versions for node-8 #1

Merged
merged 10 commits into from
Dec 19, 2018
Merged

npm: Pin versions for node-8 #1

merged 10 commits into from
Dec 19, 2018

Conversation

rzr
Copy link

@rzr rzr commented Dec 18, 2018

Node-10 to be then supported

Origin: noble@e2c476e
Forwarded: noble#851
Change-Id: I3c20732e71456cbe2b33509ccf2e0b72ca75442f
Signed-off-by: Philippe Coval [email protected]

rzr added a commit that referenced this pull request Dec 18, 2018
@rzr
npm: Fork package for support node-10
c24b245 
Update bluetooth-hci-socket for node-10

Relate-to: noble/node-bluetooth-hci-socket#84
Origin: #1
Change-Id: Ib32f0c00bb0e7dcb9a125261cd9db0d11c440c21
Signed-off-by: Philippe Coval <[email protected]>
@rzr rzr force-pushed the sandbox/rzr/master branch from c24b245 to 8cea4f0 Compare December 18, 2018 19:01
rzr added a commit that referenced this pull request Dec 18, 2018
@rzr
npm: Fork package for support node-10
8cea4f0 
Abandonware namespace was used

Update bluetooth-hci-socket for node-10

Relate-to: noble/node-bluetooth-hci-socket#84
Origin: #1
Change-Id: Ib32f0c00bb0e7dcb9a125261cd9db0d11c440c21
Signed-off-by: Philippe Coval <[email protected]>
@mrstegeman
Copy link

Old Node versions should probably be dropped from the CI configs.

@Apollon77
Copy link

The minimum approach is only to remove 0.8 because failing in tests, other idea would be to go as in bluetooth-hci-socket and test 6, 8, 10

Appveyor needs a test config file at all because not existing so far

@rzr
Copy link
Author

rzr commented Dec 19, 2018

yes PR welcome on this repo too. To validate our abilty to co maintain it (forward upstream first).
I can explain more if needed, or look at this flow:
https://www.slideshare.net/rzrfreefr/tizen-upstreamcooptdc2014pcoval/5

So please disable obsolete node versions also in upstream then I will pick patch here too

https://travis-ci.org/noble/noble/builds/469648785?utm_source=github_status&utm_medium=notification

@rzr rzr mentioned this pull request Dec 19, 2018
Open
rzr added 2 commits December 19, 2018 15:15
@rzr
npm: Pin versions for node-8
aa8b8c9 
Node-10 to be then supported

Origin: noble@e2c476e
Forwarded: noble#851
Change-Id: I3c20732e71456cbe2b33509ccf2e0b72ca75442f
Signed-off-by: Philippe Coval <[email protected]>
@rzr
travis: Prevent SSL issue on node 0.8
7cb7409 
Change-Id: I84415cf2fe5f450fd6aab3429ea14c4cb816cb91
Origin: #1
Forwarded: noble#851
Signed-off-by: Philippe Coval <[email protected]>
rzr added a commit that referenced this pull request Dec 19, 2018
@rzr
travis: Drop support of node-0.8
e68b772 
Might be obsolete and it does not worth to keep maintaining it
Relate-To: https://travis-ci.org/abandonware/noble/jobs/470026600

Change-Id: I04be1fa73626402bb81775b056cabde32ced0960
Origin: #1
Forwarded: noble#851
Signed-off-by: Philippe Coval <[email protected]>
@rzr rzr force-pushed the sandbox/rzr/master branch from e2ad3be to ee48911 Compare December 19, 2018 14:16
rzr added a commit that referenced this pull request Dec 19, 2018
@rzr
npm: Fork package for support node-10
e5856b7 
Abandonware namespace was used

Update bluetooth-hci-socket for node-10

Relate-to: noble/node-bluetooth-hci-socket#84
Origin: #1
Change-Id: Ib32f0c00bb0e7dcb9a125261cd9db0d11c440c21
Signed-off-by: Philippe Coval <[email protected]>
rzr added a commit that referenced this pull request Dec 19, 2018
@rzr
travis: Add node-10 remove 0.8
ee48911 
Change-Id: I96b7572a1872691dab80af70f1ebc811a50438fb
Origin: #1
Signed-off-by: Philippe Coval <[email protected]>
rzr added a commit that referenced this pull request Dec 19, 2018
@rzr
npm: Update vulnerable packages
747b1c7 
Then regen lock files.

Origin: #1
Change-Id: I402476a21c76a2f51ee024830647afbcd2cdb36b
Signed-off-by: Philippe Coval <[email protected]>
rzr added 6 commits December 19, 2018 15:47
@rzr
travis: Drop support of node-0.8
6875338 
Might be obsolete and it does not worth to keep maintaining it
Relate-To: https://travis-ci.org/abandonware/noble/jobs/470026600

Change-Id: I04be1fa73626402bb81775b056cabde32ced0960
Origin: #1
Forwarded: noble#851
Signed-off-by: Philippe Coval <[email protected]>
@rzr
npm: Set 0.10 as minimal engine
9137bd9 
Change-Id: I661e9105c313179526fe43585b78cf1156e1f0d9
Origin: #1
Forwarded: noble#851
Signed-off-by: Philippe Coval <[email protected]>
@rzr
npm: Fork package for support node-10
b402775 
Abandonware namespace was used

Update bluetooth-hci-socket for node-10

Relate-to: noble/node-bluetooth-hci-socket#84
Origin: #1
Change-Id: Ib32f0c00bb0e7dcb9a125261cd9db0d11c440c21
Signed-off-by: Philippe Coval <[email protected]>
@rzr
travis: Add node-10 remove 0.8
cdf09e2 
Change-Id: I96b7572a1872691dab80af70f1ebc811a50438fb
Origin: #1
Signed-off-by: Philippe Coval <[email protected]>
@rzr
travis: Drop node-4 and earlier
3505b77 
Origin: #1
Change-Id: I8eb04badb5ee427dab37e314fb43114f805f8064
Signed-off-by: Philippe Coval <[email protected]>
@rzr
npm: Drop node-4 and earlier
30a14e6 
Origin: #1
Change-Id: Iab54f45109bb4a11e172f9d9de784a0d9d436766
Signed-off-by: Philippe Coval <[email protected]>
@rzr rzr force-pushed the sandbox/rzr/master branch from ee48911 to b18226c Compare December 19, 2018 15:02
rzr added a commit that referenced this pull request Dec 19, 2018
@rzr
npm: Update vulnerable packages
b18226c 
Then regen lock files.

Origin: #1
Change-Id: I402476a21c76a2f51ee024830647afbcd2cdb36b
Signed-off-by: Philippe Coval <[email protected]>
This was referenced Dec 19, 2018
Open
Open
rzr added 2 commits December 19, 2018 16:33
@rzr
npm: Update vulnerable packages
80dbb0d 
Then regen lock files.

Origin: #1
Change-Id: I402476a21c76a2f51ee024830647afbcd2cdb36b
Signed-off-by: Philippe Coval <[email protected]>
@rzr
1.9.2-0
9b1fa0a 
Change-Id: Ib5299652916f982787b6f4ff2b0a1665cb14fc77
@rzr rzr force-pushed the sandbox/rzr/master branch from b18226c to 9b1fa0a Compare December 19, 2018 15:34
This was referenced Dec 19, 2018
Open
Open
mrstegeman
mrstegeman reviewed Dec 19, 2018
View reviewed changes
Copy link

@mrstegeman mrstegeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine other than the 2 comments.

package.json
"description": "A Node.js BLE (Bluetooth Low Energy) central library.",
"version": "1.9.1",
"version": "1.9.2-0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think npm/yarn like the -0 part very much. It was giving me warnings about it yesterday with the bluetooth-hci-socket module.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

too bad why prerelease versions are not supported ?
I wanted to have lower version than upcoming upstream version

package.json
},
"optionalDependencies": {
"bluetooth-hci-socket": "^0.5.1",
"@abandonware/bluetooth-hci-socket": "^0.5.3-0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logs welcome

@rzr rzr merged commit ecd072b into master Dec 19, 2018
@rgerr
Copy link

rgerr commented Dec 19, 2018

Any idea when node v10 will be supported for Noble?

@rzr
Copy link
Author

rzr commented Dec 19, 2018

@rgerr try master branch it should at least build ;)

rzr added a commit that referenced this pull request Aug 2, 2019
@rzr
travis: Prevent SSL issue on node 0.8
973884d 
Change-Id: I84415cf2fe5f450fd6aab3429ea14c4cb816cb91
Origin: #1
Forwarded: noble#851
Signed-off-by: Philippe Coval <[email protected]>
rzr added a commit that referenced this pull request Aug 2, 2019
@rzr
travis: Drop support of node-0.8
1662b4f 
Might be obsolete and it does not worth to keep maintaining it
Relate-To: https://travis-ci.org/abandonware/noble/jobs/470026600

Change-Id: I04be1fa73626402bb81775b056cabde32ced0960
Origin: #1
Forwarded: noble#851
Signed-off-by: Philippe Coval <[email protected]>
rzr added a commit that referenced this pull request Aug 2, 2019
@rzr
npm: Set 0.10 as minimal engine
2ce5ae1 
Change-Id: I661e9105c313179526fe43585b78cf1156e1f0d9
Origin: #1
Forwarded: noble#851
Signed-off-by: Philippe Coval <[email protected]>
rzr added a commit that referenced this pull request Aug 2, 2019
@rzr
npm: Fork package for support node-10
c4ba411 
Abandonware namespace was used

Update bluetooth-hci-socket for node-10

Relate-to: noble/node-bluetooth-hci-socket#84
Origin: #1
Change-Id: Ib32f0c00bb0e7dcb9a125261cd9db0d11c440c21
Signed-off-by: Philippe Coval <[email protected]>
rzr added a commit that referenced this pull request Aug 2, 2019
@rzr
travis: Add node-10 remove 0.8
46e4c9b 
Change-Id: I96b7572a1872691dab80af70f1ebc811a50438fb
Origin: #1
Signed-off-by: Philippe Coval <[email protected]>
rzr added a commit that referenced this pull request Aug 2, 2019
@rzr
travis: Drop node-4 and earlier
5ce7616 
Origin: #1
Change-Id: I8eb04badb5ee427dab37e314fb43114f805f8064
Signed-off-by: Philippe Coval <[email protected]>
rzr added a commit that referenced this pull request Aug 2, 2019
@rzr
npm: Drop node-4 and earlier
8d53ad2 
Origin: #1
Change-Id: Iab54f45109bb4a11e172f9d9de784a0d9d436766
Signed-off-by: Philippe Coval <[email protected]>
rzr added a commit that referenced this pull request Aug 2, 2019
@rzr
npm: Update vulnerable packages
3cd8805 
Then regen lock files.

Origin: #1
Change-Id: I402476a21c76a2f51ee024830647afbcd2cdb36b
Signed-off-by: Philippe Coval <[email protected]>
rzr added a commit that referenced this pull request Feb 20, 2020
@rzr
travis: Add node-10 remove 0.8
df3b299 
Change-Id: I96b7572a1872691dab80af70f1ebc811a50438fb
Origin: #1
Signed-off-by: Philippe Coval <[email protected]>
rzr added a commit that referenced this pull request Feb 20, 2020
@rzr
travis: Drop node-4 and earlier
5476dd8 
Origin: #1
Change-Id: I8eb04badb5ee427dab37e314fb43114f805f8064
Signed-off-by: Philippe Coval <[email protected]>
rzr added a commit that referenced this pull request Feb 20, 2020
@rzr
npm: Drop node-4 and earlier
e2d20b4 
Origin: #1
Change-Id: Iab54f45109bb4a11e172f9d9de784a0d9d436766
Signed-off-by: Philippe Coval <[email protected]>
bitcloud pushed a commit to cospired/noble that referenced this pull request Sep 21, 2020
@rzr @bitcloud
travis: Prevent SSL issue on node 0.8
6ccb172 
Change-Id: I84415cf2fe5f450fd6aab3429ea14c4cb816cb91
Origin: abandonware#1
Forwarded: noble#851
Signed-off-by: Philippe Coval <[email protected]>
bitcloud pushed a commit to cospired/noble that referenced this pull request Sep 21, 2020
@rzr @bitcloud
travis: Drop support of node-0.8
c47da26 
Might be obsolete and it does not worth to keep maintaining it
Relate-To: https://travis-ci.org/abandonware/noble/jobs/470026600

Change-Id: I04be1fa73626402bb81775b056cabde32ced0960
Origin: abandonware#1
Forwarded: noble#851
Signed-off-by: Philippe Coval <[email protected]>
bitcloud pushed a commit to cospired/noble that referenced this pull request Sep 21, 2020
@rzr @bitcloud
npm: Set 0.10 as minimal engine
c3b6d06 
Change-Id: I661e9105c313179526fe43585b78cf1156e1f0d9
Origin: abandonware#1
Forwarded: noble#851
Signed-off-by: Philippe Coval <[email protected]>
bitcloud pushed a commit to cospired/noble that referenced this pull request Sep 21, 2020
@rzr @bitcloud
npm: Fork package for support node-10
43a1019 
Abandonware namespace was used

Update bluetooth-hci-socket for node-10

Relate-to: noble/node-bluetooth-hci-socket#84
Origin: abandonware#1
Change-Id: Ib32f0c00bb0e7dcb9a125261cd9db0d11c440c21
Signed-off-by: Philippe Coval <[email protected]>
bitcloud pushed a commit to cospired/noble that referenced this pull request Sep 21, 2020
@rzr @bitcloud
travis: Add node-10 remove 0.8
fdf263a 
Change-Id: I96b7572a1872691dab80af70f1ebc811a50438fb
Origin: abandonware#1
Signed-off-by: Philippe Coval <[email protected]>
bitcloud pushed a commit to cospired/noble that referenced this pull request Sep 21, 2020
@rzr @bitcloud
travis: Drop node-4 and earlier
bebaf49 
Origin: abandonware#1
Change-Id: I8eb04badb5ee427dab37e314fb43114f805f8064
Signed-off-by: Philippe Coval <[email protected]>
bitcloud pushed a commit to cospired/noble that referenced this pull request Sep 21, 2020
@rzr @bitcloud
npm: Drop node-4 and earlier
ff3e353 
Origin: abandonware#1
Change-Id: Iab54f45109bb4a11e172f9d9de784a0d9d436766
Signed-off-by: Philippe Coval <[email protected]>
bitcloud pushed a commit to cospired/noble that referenced this pull request Sep 21, 2020
@rzr @bitcloud
npm: Update vulnerable packages
2fc9ea7 
Then regen lock files.

Origin: abandonware#1
Change-Id: I402476a21c76a2f51ee024830647afbcd2cdb36b
Signed-off-by: Philippe Coval <[email protected]>
rzr added a commit that referenced this pull request Jan 26, 2021
@rzr
travis: Add node-10 remove 0.8
742a58c 
Change-Id: I96b7572a1872691dab80af70f1ebc811a50438fb
Origin: #1
Signed-off-by: Philippe Coval <[email protected]>
rzr added a commit that referenced this pull request Jan 26, 2021
@rzr
travis: Drop node-4 and earlier
ae18609 
Origin: #1
Change-Id: I8eb04badb5ee427dab37e314fb43114f805f8064
Signed-off-by: Philippe Coval <[email protected]>
rzr added a commit that referenced this pull request Jan 26, 2021
@rzr
npm: Drop node-4 and earlier
d15d465 
Origin: #1
Change-Id: Iab54f45109bb4a11e172f9d9de784a0d9d436766
Signed-off-by: Philippe Coval <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrstegeman mrstegeman mrstegeman left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rzr @mrstegeman @Apollon77 @rgerr