fix(gateway): fix zlib data error #1364
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That error was happening because the new zlib context was trying to decompress packets from the old websocket connection, on reconnects.
Debug logs:
* As you can see from the debug logs above, the new zlib inflater tried to decompress a payload from the old websocket connection, as the client#connect event was only fired after the zlib error. So the fix is just to remove the old websocket message listener on disconnect method.
P.S.: This issue happens more often on large bots, due to high amount of incoming gateway packets. I tested on my main bot (116 guilds) and it happens, but not on my testing bot (1 guild).
Closes #1144