Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "const" over "var" in README #1229

Merged
merged 4 commits into from
Nov 12, 2021
Merged

Use "const" over "var" in README #1229

merged 4 commits into from
Nov 12, 2021

Conversation

J-Human
Copy link
Contributor

@J-Human J-Human commented Jun 26, 2021

This prefers the use of constants over the "var" keyword for the bot sample located in the ReadMe.

README.md Outdated Show resolved Hide resolved
@ghost
Copy link

ghost commented Aug 12, 2021

You specified the intents, and that seems fine, but changing var bot to const bot does not actually matter much as nobody will be stupid enough to actually reassign the bot into something else.

@bsian03
Copy link
Collaborator

bsian03 commented Aug 12, 2021

Which is also the reason why the PR hasn't been merged and why it has the farming label applied to it. Kinda obvious

@J-Human
Copy link
Contributor Author

J-Human commented Aug 12, 2021

I don't have any bad intention regarding this repository but showing this kind of tolerance seems a bit too much, honestly speaking. It's quite simple:

  • What's the exclusive "farming" tag for? It simply shows you can't handle situations well and instead shaming the author. Maybe renaming it into "invalid" would do. Furthermore, this isn't farming, I wasn't doing anything a lot of times.
  • If this PR is too low for your standards, why don't you close it?

What's the purpose for not minding this as if it's useless? I get avergateftw's point but I feel having a good code convention in your sample will help. It just shows that you have good habits.

@bsian03
Copy link
Collaborator

bsian03 commented Aug 12, 2021

The PR is valid, it's just low effort. Those kinds of PRs should have the farming label applied. I'm not discriminating your PRs, I've had to apply the same label on my own PRs updating the readme

@bsian03
Copy link
Collaborator

bsian03 commented Aug 12, 2021

My wording earlier might not've been the best (I did literally just wake up) so if it came across the wrong way, apologies

README.md Outdated Show resolved Hide resolved
@abalabahaha abalabahaha changed the title Use "const" over "var" Use "const" over "var" in README Nov 12, 2021
@abalabahaha abalabahaha merged commit 6e76e52 into abalabahaha:dev Nov 12, 2021
@J-Human J-Human deleted the fix-bot-sample branch November 12, 2021 00:50
@abalabahaha abalabahaha added this to the 0.16.0 milestone Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants