-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use "const" over "var" in README #1229
Conversation
You specified the intents, and that seems fine, but changing |
Which is also the reason why the PR hasn't been merged and why it has the farming label applied to it. Kinda obvious |
I don't have any bad intention regarding this repository but showing this kind of tolerance seems a bit too much, honestly speaking. It's quite simple:
What's the purpose for not minding this as if it's useless? I get avergateftw's point but I feel having a good code convention in your sample will help. It just shows that you have good habits. |
The PR is valid, it's just low effort. Those kinds of PRs should have the farming label applied. I'm not discriminating your PRs, I've had to apply the same label on my own PRs updating the readme |
My wording earlier might not've been the best (I did literally just wake up) so if it came across the wrong way, apologies |
This prefers the use of constants over the "var" keyword for the bot sample located in the ReadMe.