fix(Channels): OldChannel permissionOverwrites showing updated perms (#…

…1511)
abalabahaha · Jun 11, 2024 · f48547b · f48547b
1 parent 692521c
commit f48547b
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 20 deletions.
diff --git a/lib/structures/CategoryChannel.js b/lib/structures/CategoryChannel.js
@@ -23,12 +23,9 @@ class CategoryChannel extends GuildChannel {
             this.position = data.position;
         }
         if(data.permission_overwrites !== undefined) {
-            if(this.permissionOverwrites === undefined) {
-                this.permissionOverwrites = new Collection(PermissionOverwrite);
-            }
-            this.permissionOverwrites.clear();
+            this.permissionOverwrites = new Collection(PermissionOverwrite);
             data.permission_overwrites.forEach((overwrite) => {
-                this.permissionOverwrites.update(overwrite);
+                this.permissionOverwrites.add(overwrite);
             });
         }
     }

diff --git a/lib/structures/MediaChannel.js b/lib/structures/MediaChannel.js
@@ -51,12 +51,9 @@ class MediaChannel extends GuildChannel {
             this.nsfw = data.nsfw;
         }
         if(data.permission_overwrites !== undefined) {
-            if(this.permissionOverwrites === undefined) {
-                this.permissionOverwrites = new Collection(PermissionOverwrite);
-            }
-            this.permissionOverwrites.clear();
+            this.permissionOverwrites = new Collection(PermissionOverwrite);
             data.permission_overwrites.forEach((overwrite) => {
-                this.permissionOverwrites.update(overwrite);
+                this.permissionOverwrites.add(overwrite);
             });
         }
         if(data.position !== undefined) {

diff --git a/lib/structures/TextChannel.js b/lib/structures/TextChannel.js
@@ -26,12 +26,9 @@ class TextChannel extends GuildTextableChannel {
             this.position = data.position;
         }
         if(data.permission_overwrites !== undefined) {
-            if(this.permissionOverwrites === undefined) {
-                this.permissionOverwrites = new Collection(PermissionOverwrite);
-            }
-            this.permissionOverwrites.clear();
+            this.permissionOverwrites = new Collection(PermissionOverwrite);
             data.permission_overwrites.forEach((overwrite) => {
-                this.permissionOverwrites.update(overwrite);
+                this.permissionOverwrites.add(overwrite);
             });
         }
         if(data.nsfw !== undefined) {

diff --git a/lib/structures/VoiceChannel.js b/lib/structures/VoiceChannel.js
@@ -30,12 +30,9 @@ class VoiceChannel extends GuildTextableChannel {
             this.position = data.position;
         }
         if(data.permission_overwrites !== undefined) {
-            if(this.permissionOverwrites === undefined) {
-                this.permissionOverwrites = new Collection(PermissionOverwrite);
-            }
-            this.permissionOverwrites.clear();
+            this.permissionOverwrites = new Collection(PermissionOverwrite);
             data.permission_overwrites.forEach((overwrite) => {
-                this.permissionOverwrites.update(overwrite);
+                this.permissionOverwrites.add(overwrite);
             });
         }
         if(data.nsfw !== undefined) {